From patchwork Fri Sep 10 20:25:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Ball X-Patchwork-Id: 178362 Return-path: X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on void.printf.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.9 tests=RCVD_IN_DNSWL_LOW autolearn=disabled version=3.2.5 Envelope-to: chris@printf.net Delivery-date: Fri, 10 Sep 2010 21:25:32 +0100 Received: from lists.laptop.org ([18.85.2.145] helo=mail.laptop.org) by void.printf.net with esmtp (Exim 4.69) (envelope-from ) id 1OuAA8-0000l3-MT for chris@printf.net; Fri, 10 Sep 2010 21:25:32 +0100 Received: by mail.laptop.org (Postfix) id 789C723C72; Fri, 10 Sep 2010 16:25:12 -0400 (EDT) Delivered-To: cjb@laptop.org Received: from spam.laptop.org (spam.laptop.org [18.85.46.23]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.laptop.org (Postfix) with ESMTPS id 2890123C70 for ; Fri, 10 Sep 2010 16:25:12 -0400 (EDT) X-ASG-Debug-ID: 1284150321-0b7487780002-zHW3sV Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by spam.laptop.org with ESMTP id 4HaPy2Q4I4QcOgJy for ; Fri, 10 Sep 2010 16:25:21 -0400 (EDT) X-Barracuda-Envelope-From: linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059Ab0IJUZS (ORCPT ); Fri, 10 Sep 2010 16:25:18 -0400 Received: from void.printf.net ([89.145.121.20]:53234 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755238Ab0IJUZR (ORCPT ); Fri, 10 Sep 2010 16:25:17 -0400 Received: from chris by void.printf.net with local (Exim 4.69) (envelope-from ) id 1OuA9q-0000ku-Fq; Fri, 10 Sep 2010 21:25:14 +0100 Date: Fri, 10 Sep 2010 21:25:14 +0100 From: Chris Ball To: David Vrabel Cc: Andrew Morton , linux-mmc@vger.kernel.org X-ASG-Orig-Subj: Re: [PATCH v2] mmc: USB SD Host Controller (USHC) driver Subject: Re: [PATCH v2] mmc: USB SD Host Controller (USHC) driver Message-ID: <20100910202514.GC2623@void.printf.net> References: <1283436908-12097-1-git-send-email-david.vrabel@csr.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1283436908-12097-1-git-send-email-david.vrabel@csr.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Barracuda-Connect: vger.kernel.org[209.132.180.67] X-Barracuda-Start-Time: 1284150321 X-Barracuda-URL: http://18.85.46.23:8000/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at laptop.org X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=5.5 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.40504 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c index 2d0cc2c..b4ead4a 100644 --- a/drivers/mmc/host/ushc.c +++ b/drivers/mmc/host/ushc.c @@ -456,8 +456,7 @@ static int ushc_probe(struct usb_interface *intf, const struct usb_device_id *id mmc->caps |= (ushc->caps & USHC_GET_CAPS_HIGH_SPD) ? MMC_CAP_SD_HIGHSPEED : 0; mmc->max_seg_size = 512*511; - mmc->max_hw_segs = 1; - mmc->max_phys_segs = 1; + mmc->max_segs = 1; mmc->max_req_size = 512*511; mmc->max_blk_size = 512; mmc->max_blk_count = 511;