From patchwork Wed Jan 5 20:57:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Ball X-Patchwork-Id: 455061 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p05KvKHV004317 for ; Wed, 5 Jan 2011 20:57:20 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730Ab1AEU5T (ORCPT ); Wed, 5 Jan 2011 15:57:19 -0500 Received: from void.printf.net ([89.145.121.20]:35896 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006Ab1AEU5T (ORCPT ); Wed, 5 Jan 2011 15:57:19 -0500 Received: from chris by void.printf.net with local (Exim 4.69) (envelope-from ) id 1PaaQ1-0002zi-M3; Wed, 05 Jan 2011 20:57:17 +0000 Date: Wed, 5 Jan 2011 20:57:17 +0000 From: Chris Ball To: Arnd Hannemann Cc: linux-mmc@vger.kernel.org, Magnus Damm , linux-sh@vger.kernel.org, g.liakhovetski@gmx.de, Ian Molton , Samuel Ortiz Subject: Re: [PATCH 1/6 v3] mmc: tmio: implement SDIO IRQ Message-ID: <20110105205717.GG9198@void.printf.net> References: <1293574956-30035-1-git-send-email-arnd@arndnet.de> <1293574956-30035-2-git-send-email-arnd@arndnet.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1293574956-30035-2-git-send-email-arnd@arndnet.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 05 Jan 2011 20:57:20 +0000 (UTC) diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c index d74cdac..8d55b8a 100644 --- a/drivers/mmc/host/tmio_mmc.c +++ b/drivers/mmc/host/tmio_mmc.c @@ -298,8 +298,9 @@ static void tmio_mmc_clk_stop(struct tmio_mmc_host *host) /* * Testing on sh-mobile showed that SDIO IRQs are unmasked when - * CTL_CLK_AND_WAIT_CTL gets written, so we have to disable the device IRQ - * here and restore the SDIO IRQ mask before re-enabling the device IRQ. + * CTL_CLK_AND_WAIT_CTL gets written, so we have to disable the + * device IRQ here and restore the SDIO IRQ mask before + * re-enabling the device IRQ. */ if (pdata->flags & TMIO_MMC_SDIO_IRQ) disable_irq(host->irq); @@ -623,8 +624,9 @@ static irqreturn_t tmio_mmc_irq(int irq, void *devid) sd_ctrl_write16(host, CTL_SDIO_STATUS, sdio_status & ~TMIO_SDIO_MASK_ALL); if (sdio_ireg && !host->sdio_irq_enabled) { - pr_warning("tmio_mmc: Spurious SDIO IRQ, disabling! 0x%04x 0x%04x 0x%04x\n", - sdio_status, sdio_irq_mask, sdio_ireg); + pr_warning("tmio_mmc: Spurious SDIO IRQ, disabling! " + "0x%04x 0x%04x 0x%04x\n", + sdio_status, sdio_irq_mask, sdio_ireg); tmio_mmc_enable_sdio_irq(host->mmc, 0); goto out; }