From patchwork Mon Jan 10 00:17:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Ball X-Patchwork-Id: 467341 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0A0HhSc016115 for ; Mon, 10 Jan 2011 00:17:44 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999Ab1AJARl (ORCPT ); Sun, 9 Jan 2011 19:17:41 -0500 Received: from void.printf.net ([89.145.121.20]:59189 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818Ab1AJARl (ORCPT ); Sun, 9 Jan 2011 19:17:41 -0500 Received: from chris by void.printf.net with local (Exim 4.69) (envelope-from ) id 1Pc5S6-00076W-5j; Mon, 10 Jan 2011 00:17:38 +0000 Date: Mon, 10 Jan 2011 00:17:38 +0000 From: Chris Ball To: Sekhar Nori Cc: linux-mmc@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com, Alagu Sankar Subject: Re: [PATCH v5] mmc: davinci: add support for SDIO irq handling Message-ID: <20110110001738.GB26898@void.printf.net> References: <1294038807-16450-1-git-send-email-nsekhar@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1294038807-16450-1-git-send-email-nsekhar@ti.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 10 Jan 2011 00:17:44 +0000 (UTC) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 6b09752..0076c74 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -882,7 +882,7 @@ mmc_davinci_xfer_done(struct mmc_davinci_host *host, struct mmc_data *data) * 2.1.6): Signal SDIO interrupt only if it is enabled by core */ if (host->sdio_int && !(readl(host->base + DAVINCI_SDIOST0) & - SDIOST0_DAT1_HI)) { + SDIOST0_DAT1_HI)) { writel(SDIOIST_IOINT, host->base + DAVINCI_SDIOIST); mmc_signal_sdio_irq(host->mmc); } @@ -962,7 +962,7 @@ static irqreturn_t mmc_davinci_sdio_irq(int irq, void *dev_id) status = readl(host->base + DAVINCI_SDIOIST); if (status & SDIOIST_IOINT) { dev_dbg(mmc_dev(host->mmc), - "SDIO interrupt status %x\n", status); + "SDIO interrupt status %x\n", status); writel(status | SDIOIST_IOINT, host->base + DAVINCI_SDIOIST); mmc_signal_sdio_irq(host->mmc); } @@ -1124,12 +1124,12 @@ static void mmc_davinci_enable_sdio_irq(struct mmc_host *mmc, int enable) } else { host->sdio_int = true; writel(readl(host->base + DAVINCI_SDIOIEN) | - SDIOIEN_IOINTEN, host->base + DAVINCI_SDIOIEN); + SDIOIEN_IOINTEN, host->base + DAVINCI_SDIOIEN); } } else { host->sdio_int = false; writel(readl(host->base + DAVINCI_SDIOIEN) & ~SDIOIEN_IOINTEN, - host->base + DAVINCI_SDIOIEN); + host->base + DAVINCI_SDIOIEN); } } @@ -1331,7 +1331,7 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev) if (host->sdio_irq >= 0) { ret = request_irq(host->sdio_irq, mmc_davinci_sdio_irq, 0, - mmc_hostname(mmc), host); + mmc_hostname(mmc), host); if (!ret) mmc->caps |= MMC_CAP_SDIO_IRQ; }