From patchwork Wed Jul 17 01:22:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 2828382 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 472609F9EC for ; Wed, 17 Jul 2013 01:22:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5C210201ED for ; Wed, 17 Jul 2013 01:22:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E257201B2 for ; Wed, 17 Jul 2013 01:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750971Ab3GQBWy (ORCPT ); Tue, 16 Jul 2013 21:22:54 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:42974 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893Ab3GQBWx (ORCPT ); Tue, 16 Jul 2013 21:22:53 -0400 Received: from ayumi.isobedori.kobe.vergenet.net (p2173-ipbfp805kobeminato.hyogo.ocn.ne.jp [124.101.179.173]) by kirsty.vergenet.net (Postfix) with ESMTP id DE7B8266CEE; Wed, 17 Jul 2013 11:22:51 +1000 (EST) Received: by ayumi.isobedori.kobe.vergenet.net (Postfix, from userid 7100) id 70B6DEDE5E7; Wed, 17 Jul 2013 10:22:50 +0900 (JST) Date: Wed, 17 Jul 2013 10:22:50 +0900 From: Simon Horman To: Magnus Damm Cc: Guennadi Liakhovetski , SH-Linux , linux-mmc@vger.kernel.org, Chris Ball , Kuninori Morimoto Subject: Re: [PATCH v4 5/7] mmc: SDHI: add DT compatibility strings for further SoCs Message-ID: <20130717012247.GA2797@verge.net.au> References: <20130710011834.GA27240@verge.net.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130710011834.GA27240@verge.net.au> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jul 10, 2013 at 10:18:35AM +0900, Simon Horman wrote: > On Tue, Jul 09, 2013 at 06:06:00PM +0900, Magnus Damm wrote: > > On Tue, Jul 9, 2013 at 4:43 PM, Guennadi Liakhovetski > > wrote: > > > Add further OF compatibility strings to the SDHI driver to be able to > > > precisely control driver's behaviour on each of them. > > > > > > Signed-off-by: Guennadi Liakhovetski > > > --- > > > > > > v4: > > > 1. added r8a7778 and r8a7779 per Morimoto-san's request > > > 2. sh* and r8a* entries now sorted alphabetically > > > > This looks good to me, thanks. > > > > Acked-by: Magnus Damm > > Thanks, I have queued this up for v3.12 in the dt branch. > It should appear in renesas-next-20130710 Reviewing this, I now think that it should got through the MMC tree. Chris, could you consider the patch below? From: Guennadi Liakhovetski mmc: SDHI: add DT compatibility strings for further SoCs Add further OF compatibility strings to the SDHI driver to be able to precisely control driver's behaviour on each of them. Signed-off-by: Guennadi Liakhovetski Acked-by: Magnus Damm Acked-by: Simon Horman --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c index ebea749..afa1bba 100644 --- a/drivers/mmc/host/sh_mobile_sdhi.c +++ b/drivers/mmc/host/sh_mobile_sdhi.c @@ -129,7 +129,12 @@ static const struct sh_mobile_sdhi_ops sdhi_ops = { static const struct of_device_id sh_mobile_sdhi_of_match[] = { { .compatible = "renesas,shmobile-sdhi" }, { .compatible = "renesas,sh7372-sdhi" }, + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,r8a7778-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,r8a7779-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, {}, }; MODULE_DEVICE_TABLE(of, sh_mobile_sdhi_of_match);