From patchwork Wed Sep 25 07:12:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 2939881 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 719799F288 for ; Wed, 25 Sep 2013 07:12:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D88BA201C4 for ; Wed, 25 Sep 2013 07:12:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BEB220212 for ; Wed, 25 Sep 2013 07:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751764Ab3IYHM3 (ORCPT ); Wed, 25 Sep 2013 03:12:29 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:48617 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949Ab3IYHM3 (ORCPT ); Wed, 25 Sep 2013 03:12:29 -0400 Received: from ayumi.isobedori.kobe.vergenet.net (p6221-ipbfp1004kobeminato.hyogo.ocn.ne.jp [118.10.144.221]) by kirsty.vergenet.net (Postfix) with ESMTP id 6B08F25BFB0; Wed, 25 Sep 2013 17:12:28 +1000 (EST) Received: by ayumi.isobedori.kobe.vergenet.net (Postfix, from userid 7100) id 171BE6CE045; Wed, 25 Sep 2013 16:12:27 +0900 (JST) Date: Wed, 25 Sep 2013 16:12:27 +0900 From: Simon Horman To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Chris Ball , Nobuyuki HIRAI , Guennadi Liakhovetski Subject: Re: [PATCH 5/6] ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal Message-ID: <20130925071226.GP6663@verge.net.au> References: <1373484077-10460-1-git-send-email-g.liakhovetski@gmx.de> <1373484077-10460-6-git-send-email-g.liakhovetski@gmx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1373484077-10460-6-git-send-email-g.liakhovetski@gmx.de> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jul 10, 2013 at 09:21:16PM +0200, Guennadi Liakhovetski wrote: > MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform > parameter has to be added to disable it on ape6evm. > > Signed-off-by: Guennadi Liakhovetski > --- > arch/arm/mach-shmobile/board-ape6evm.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c > index e9e2108e..96a6994 100644 > --- a/arch/arm/mach-shmobile/board-ape6evm.c > +++ b/arch/arm/mach-shmobile/board-ape6evm.c > @@ -77,6 +77,7 @@ static struct sh_mmcif_plat_data mmcif0_pdata = { > .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE, > .slave_id_tx = SHDMA_SLAVE_MMCIF0_TX, > .slave_id_rx = SHDMA_SLAVE_MMCIF0_RX, > + .ccs_unsupported = true, > }; > > static struct resource mmcif0_resources[] = { Thanks, I have queued up the following for v3.13. From: Guennadi Liakhovetski ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform parameter has to be added to disable it on ape6evm. Signed-off-by: Guennadi Liakhovetski Signed-off-by: Simon Horman --- arch/arm/mach-shmobile/board-ape6evm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c index 02be420..0365d2e 100644 --- a/arch/arm/mach-shmobile/board-ape6evm.c +++ b/arch/arm/mach-shmobile/board-ape6evm.c @@ -162,6 +162,7 @@ static struct regulator_consumer_supply vcc_sdhi1_consumers[] = /* MMCIF */ static const struct sh_mmcif_plat_data mmcif0_pdata __initconst = { .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE, + .ccs_unsupported = true, }; static const struct resource mmcif0_resources[] __initconst = {