From patchwork Mon Jan 13 18:46:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 3479921 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 95507C02DC for ; Mon, 13 Jan 2014 18:46:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1EC982012B for ; Mon, 13 Jan 2014 18:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66268200E5 for ; Mon, 13 Jan 2014 18:46:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbaAMSqv (ORCPT ); Mon, 13 Jan 2014 13:46:51 -0500 Received: from sauhun.de ([89.238.76.85]:36335 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbaAMSqv (ORCPT ); Mon, 13 Jan 2014 13:46:51 -0500 Received: from p4fe254f4.dip0.t-ipconnect.de ([79.226.84.244]:59776 helo=localhost) by pokefinder.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1W2mX9-0004uJ-2m; Mon, 13 Jan 2014 19:46:47 +0100 Date: Mon, 13 Jan 2014 19:46:45 +0100 From: Wolfram Sang To: Chris Ball Cc: linux-mmc@vger.kernel.org, Jaehoon Chung , Kyungmin Park , H Hartley Sweeten Subject: Re: [PATCH] mmc: core: sd: implement proper support for sd3.0 au sizes Message-ID: <20140113184645.GA17979@katana> References: <1385428585-17516-1-git-send-email-wsa@the-dreams.de> <20140113124117.GD2586@katana> <861u0bdahb.fsf@void.printf.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <861u0bdahb.fsf@void.printf.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jan 13, 2014 at 06:04:32PM +0000, Chris Ball wrote: > Hi Wolfram, > > On Mon, Jan 13 2014, Wolfram Sang wrote: > > On Tue, Nov 26, 2013 at 02:16:25AM +0100, Wolfram Sang wrote: > >> This reverts and updates commit 77776fd0a4cc541b9a528eacc1d31ca47eb1ae7a > >> ("mmc: sd: fix the maximum au_size for SD3.0"). The au_size for SD3.0 > >> cannot be achieved by a simple bit shift, so this needs to be > >> implemented differently. Also, don't print the warning in case of 0 > >> since 'not defined' is different from 'invalid'. > > > > Ping! Chris are you there? This got reviewed and acked, and I'd even > > think this could be suitable for stable. > > Sorry about that! I agree, pushed to mmc-next for 3.14 with stable@ tag. Thanks. As buildbot reports, this will probably need another patch for blackfin :/ Sorry about that! From: Wolfram Sang Subject: [PATCH] mmc: core: add #include to support size defintions Fixes an error found by buildbot on blackfin after adding the fix for sd3.0 au sizes: >> drivers/mmc/core/sd.c:49:5: error: 'SZ_16K' undeclared here (not in a function) Signed-off-by: Wolfram Sang --- drivers/mmc/core/sd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index 6f42050..585d44d 100644 --- a/drivers/mmc/core/sd.c +++ b/drivers/mmc/core/sd.c @@ -11,6 +11,7 @@ */ #include +#include #include #include #include