| Message ID | 20150221151516.1b3bc8ae@notabene.brown (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Neil, On 02/21/2015 05:15 AM, NeilBrown wrote: > > From: NeilBrown <neil@brown.name> > > The current error-path code (when gpiod_get_index() reports > an error) can never free pwrseq->reset_gpios[0], but might > try to tree pwrseq->reset_gpios[-1], which has unfortunate > consequences. > > Signed-off-by: NeilBrown <neil@brown.name> > Fixes: 934f1f48330ed695927a51fa068dc5d673f2da19 > > Right, sorry for the silly mistake. Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21 February 2015 at 05:15, NeilBrown <neilb@suse.de> wrote: > > From: NeilBrown <neil@brown.name> > > The current error-path code (when gpiod_get_index() reports > an error) can never free pwrseq->reset_gpios[0], but might > try to tree pwrseq->reset_gpios[-1], which has unfortunate > consequences. > > Signed-off-by: NeilBrown <neil@brown.name> > Fixes: 934f1f48330ed695927a51fa068dc5d673f2da19 Applied, thanks! Kind regards Uffe > > > diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c > index e9f1d8d84613..c53f14a7ce54 100644 > --- a/drivers/mmc/core/pwrseq_simple.c > +++ b/drivers/mmc/core/pwrseq_simple.c > @@ -124,7 +124,7 @@ int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) > PTR_ERR(pwrseq->reset_gpios[i]) != -ENOSYS) { > ret = PTR_ERR(pwrseq->reset_gpios[i]); > > - while (--i) > + while (i--) > gpiod_put(pwrseq->reset_gpios[i]); > > goto clk_put; -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c index e9f1d8d84613..c53f14a7ce54 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -124,7 +124,7 @@ int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) PTR_ERR(pwrseq->reset_gpios[i]) != -ENOSYS) { ret = PTR_ERR(pwrseq->reset_gpios[i]); - while (--i) + while (i--) gpiod_put(pwrseq->reset_gpios[i]); goto clk_put;