| Message ID | 20161115101232.3854-3-jh80.chung@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016/11/15 18:12, Jaehoon Chung wrote: > If display the debug message, this message should be spamming. > If flags is maintained the previous value, didn't display the debug > message. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > Tested-by: Heiko Stuebner <heiko@sntech.de> Looks correct to me, Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > drivers/mmc/host/dw_mmc.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index e53899e..6c0c4c5 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1537,13 +1537,10 @@ static int dw_mci_get_cd(struct mmc_host *mmc) > == 0 ? 1 : 0; > > spin_lock_bh(&host->lock); > - if (present) { > - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); > + if (present && !test_and_set_bit(DW_MMC_CARD_PRESENT, &slot->flags)) > dev_dbg(&mmc->class_dev, "card is present\n"); > - } else { > - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); > + else if (!test_and_clear_bit(DW_MMC_CARD_PRESENT, &slot->flags)) > dev_dbg(&mmc->class_dev, "card is not present\n"); > - } > spin_unlock_bh(&host->lock); > > return present; >
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index e53899e..6c0c4c5 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1537,13 +1537,10 @@ static int dw_mci_get_cd(struct mmc_host *mmc) == 0 ? 1 : 0; spin_lock_bh(&host->lock); - if (present) { - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); + if (present && !test_and_set_bit(DW_MMC_CARD_PRESENT, &slot->flags)) dev_dbg(&mmc->class_dev, "card is present\n"); - } else { - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); + else if (!test_and_clear_bit(DW_MMC_CARD_PRESENT, &slot->flags)) dev_dbg(&mmc->class_dev, "card is not present\n"); - } spin_unlock_bh(&host->lock); return present;