From patchwork Fri Jan 20 09:50:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 9527865 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4D5016020B for ; Fri, 20 Jan 2017 10:01:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3EB0B285F5 for ; Fri, 20 Jan 2017 10:01:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 33A5F28616; Fri, 20 Jan 2017 10:01:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 262F928618 for ; Fri, 20 Jan 2017 10:01:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751613AbdATKBd (ORCPT ); Fri, 20 Jan 2017 05:01:33 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:46295 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbdATKBb (ORCPT ); Fri, 20 Jan 2017 05:01:31 -0500 Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OK2003GPONO5K30@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Fri, 20 Jan 2017 18:50:12 +0900 (KST) Received: from epsmges5p1.samsung.com (unknown [182.195.40.67]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20170120095012epcas1p2d59993d9a2c17dbd21305bbdc5f9fd73~bcfgmxcBr0631806318epcas1p2W; Fri, 20 Jan 2017 09:50:12 +0000 (GMT) Received: from epcas5p1.samsung.com ( [182.195.41.39]) by epsmges5p1.samsung.com (EPCPMTA) with SMTP id 4D.2A.14952.45DD1885; Fri, 20 Jan 2017 18:50:12 +0900 (KST) Received: from epcpsbgm2new.samsung.com (u27.gpu120.samsung.co.kr [203.254.230.27]) by epcas5p4.samsung.com (KnoxPortal) with ESMTP id 20170120095012epcas5p4b5e0955e3e75e96b37ef1ef66fb501f6~bcfgVXCjy1579215792epcas5p48; Fri, 20 Jan 2017 09:50:12 +0000 (GMT) X-AuditID: b6c32a2c-f79bc6d000003a68-1c-5881dd541e24 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id E7.BB.26370.45DD1885; Fri, 20 Jan 2017 18:50:12 +0900 (KST) Received: from localhost.localdomain ([10.113.62.216]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OK2008EQONN0MC0@mmp1.samsung.com>; Fri, 20 Jan 2017 18:50:12 +0900 (KST) From: Jaehoon Chung To: linux-mmc@vger.kernel.org Cc: ulf.hansson@linaro.org, adrian.hunter@intel.com, Jaehoon Chung Subject: [PATCH 3/3] mmc: sdhci-s3c: use the bitops API for bit operation Date: Fri, 20 Jan 2017 18:50:04 +0900 Message-id: <20170120095004.14509-4-jh80.chung@samsung.com> X-Mailer: git-send-email 2.10.2 In-reply-to: <20170120095004.14509-1-jh80.chung@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsWy7bCmum7I3cYIg+5fOhYnn6xhs7jxq43V 4sj/fkaL42vDHVg8Fu95yeRx59oeNo++LasYPT5vkgtgiUq1yUhNTEktUkjNS85PycxLt1Xy Do53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAHaqKRQlphTChQKSCwuVtK3synKLy1JVcjI Ly6xVYo2NDTSMzQw1zMyMtIzMY61MjIFKklIzWj484Kx4DtvxeHnPUwNjO+4uxg5OSQETCQW vJ7GDmGLSVy4t56ti5GLQ0hgKaPEhmvPmCCcdiaJuXu7mGA6jpxsZYFILGeUuHRwBlTLD0aJ U4cPgM1iE9CR2P7tOFiHiICsxM8/F9hAbGaBWIljTzaAxYUFPCXu3tsCZHNwsAioSrS0KICE eQWsJc7POg11krzEwvNHwMo5BWwkdt94wQqyS0LgMpvEoQOP2UF6JYDmbzrADFHvIrF7/ymo XmGJV8e3QNnSEn+X3mKE6O1mlPj3ZSMbhNPDKHFr62qo14wl7j+4xwxxKJ9E7+8nTBALeCU6 2oQgSjwk1mxtZ4WwHSXOn2oCKxcS6GeUePRXegKjzAJGhlWMYqkFxbnpqcWmBYZ6xYm5xaV5 6XrJ+bmbGMEJRUtnB+O9Bd6HGAU4GJV4eHecaIgQYk0sK67MPcQowcGsJML75GZjhBBvSmJl VWpRfnxRaU5q8SFGU2AwTWSWEk3OBya7vJJ4QxMzQxMjSyA0NzRXEuddUGEdISSQnliSmp2a WpBaBNPHxMEp1cC4uC3F25C959x1J/3ymqjl83ZV98Xl6H3Q3v76wJ3C2fkeJ2Ntdgj/Ku22 fDZx55azYZL96kGvXtgubzBq8PaSOvdM/rr5Vb0Gp4PWUkbz7DeI/GKXV+2YWKh2d0d0/KK8 hNn8/74fWJ3+3/Z7zcfko0424prFv2qZebO0ktd+Mpuw/Hvcye9KLMUZiYZazEXFiQCpzq8l PgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t9jAd2Qu40RBqvXSlucfLKGzeLGrzZW iyP/+xktjq8Nd2DxWLznJZPHnWt72Dz6tqxi9Pi8SS6AJcrNJiM1MSW1SCE1Lzk/JTMv3VYp NMRN10JJIS8xN9VWKULXNyRISaEsMacUyDMyQAMOzgHuwUr6dgluGQ1/XjAWfOetOPy8h6mB 8R13FyMnh4SAicSRk60sELaYxIV769m6GLk4hASWMkq8vvqLEcL5wShxY94sJpAqNgEdie3f joPZIgKyEj//XGADsZkFYiWmfTjMDGILC3hK3L23BaiGg4NFQFWipUUBJMwrYC1xftZpdohl 8hILzx8BG8MpYCOx+8YLVhBbCKhmyYPNLBMYeRcwMqxilEgtSC4oTkrPNcpLLdcrTswtLs1L 10vOz93ECA7UZ9I7GA/vcj/EKMDBqMTDmyHRGCHEmlhWXJl7iFGCg1lJhPfJTaAQb0piZVVq UX58UWlOavEhRlOguyYyS4km5wOjKK8k3tDE3MTc2MDC3NLSxEhJnLdx9rNwIYH0xJLU7NTU gtQimD4mDk6pBsbg2W5d3hPNpIoWySgVbvCcGKsz/1FctOL+0OJLM15r6zh85Db6qNGw50hs yNK9ftL6rGxzQ7oXn61V2dOmfLrmoVVbfhRnnMyXFLZILt7Lqmp2l/huMBawef83+3Ho8mT7 r58MVrs4122vCIueXdSUYzFvR9OOovVH+EOldadY/jhf59DnqMRSnJFoqMVcVJwIANelKw5q AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170120095012epcas5p4b5e0955e3e75e96b37ef1ef66fb501f6 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbUzUvU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170120095012epcas5p4b5e0955e3e75e96b37ef1ef66fb501f6 X-RootMTR: 20170120095012epcas5p4b5e0955e3e75e96b37ef1ef66fb501f6 References: <20170120095004.14509-1-jh80.chung@samsung.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use the bitops API instead of shifting directly. Signed-off-by: Jaehoon Chung --- drivers/mmc/host/sdhci-s3c.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index e8b57cd..6c102d8 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -34,24 +34,24 @@ #define MAX_BUS_CLK (4) #define S3C_SDHCI_CONTROL2 (0x80) -#define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR (1 << 31) -#define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK (1 << 30) -#define S3C_SDHCI_CTRL2_ENFBCLKRX (1 << 14) +#define S3C64XX_SDHCI_CTRL2_ENSTAASYNCCLR BIT(31) +#define S3C64XX_SDHCI_CTRL2_ENCMDCNFMSK BIT(30) +#define S3C_SDHCI_CTRL2_ENFBCLKRX BIT(14) #define S3C_SDHCI_CTRL2_DFCNT_MASK (0x3 << 9) #define S3C_SDHCI_CTRL2_DFCNT_SHIFT (9) #define S3C_SDHCI_CTRL2_DFCNT_NONE (0x0 << 9) #define S3C_SDHCI_CTRL2_DFCNT_4SDCLK (0x1 << 9) #define S3C_SDHCI_CTRL2_DFCNT_16SDCLK (0x2 << 9) #define S3C_SDHCI_CTRL2_DFCNT_64SDCLK (0x3 << 9) -#define S3C_SDHCI_CTRL2_ENCLKOUTHOLD (1 << 8) +#define S3C_SDHCI_CTRL2_ENCLKOUTHOLD BIT(8) #define S3C_SDHCI_CTRL2_SELBASECLK_MASK (0x3 << 4) #define S3C_SDHCI_CTRL2_SELBASECLK_SHIFT (4) #define S3C_SDHCI_CONTROL3 (0x84) -#define S3C_SDHCI_CTRL3_FCSEL3 (1 << 31) -#define S3C_SDHCI_CTRL3_FCSEL2 (1 << 23) -#define S3C_SDHCI_CTRL3_FCSEL1 (1 << 15) -#define S3C_SDHCI_CTRL3_FCSEL0 (1 << 7) +#define S3C_SDHCI_CTRL3_FCSEL3 BIT(31) +#define S3C_SDHCI_CTRL3_FCSEL2 BIT(23) +#define S3C_SDHCI_CTRL3_FCSEL1 BIT(15) +#define S3C_SDHCI_CTRL3_FCSEL0 BIT(7) #define S3C64XX_SDHCI_CONTROL4 (0x8C) #define S3C64XX_SDHCI_CONTROL4_DRIVE_9mA (0x3 << 16)