From patchwork Tue Apr 11 10:20:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 9674885 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 270A5600CB for ; Tue, 11 Apr 2017 10:28:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C0B42854E for ; Tue, 11 Apr 2017 10:28:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2050028550; Tue, 11 Apr 2017 10:28:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A23D62854E for ; Tue, 11 Apr 2017 10:28:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbdDKK1g (ORCPT ); Tue, 11 Apr 2017 06:27:36 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:33982 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751685AbdDKK0C (ORCPT ); Tue, 11 Apr 2017 06:26:02 -0400 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v3BAJbRc003554; Tue, 11 Apr 2017 03:25:37 -0700 Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 29pw7kf26h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 11 Apr 2017 03:25:37 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 11 Apr 2017 03:25:36 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Tue, 11 Apr 2017 03:25:36 -0700 Received: from xhacker.marvell.com (unknown [10.37.130.129]) by maili.marvell.com (Postfix) with ESMTP id A84FC3F703F; Tue, 11 Apr 2017 03:25:34 -0700 (PDT) From: Jisheng Zhang To: , CC: , , , Jisheng Zhang Subject: [PATCH 2/2] mmc: sdhci: provide isr for card-detect interrupts Date: Tue, 11 Apr 2017 18:20:56 +0800 Message-ID: <20170411102056.2869-3-jszhang@marvell.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170411102056.2869-1-jszhang@marvell.com> References: <20170411102056.2869-1-jszhang@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-04-11_08:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704110085 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We found one issue on BG4CT platforms with GPIO for sdcar card detect interrupt: remove sdcard when there's read write access to the sdcard, sometimes the card remove event can't be handled for a long time, so the system still think the sdcard is still plugged in. It turns out that the sdhci_card_event() is missing in common slot gpio's card detect isr. We fix this issue by providing sdhci's own isr for card-detect interrupts. In this own isr, we call sdhci_card_event() then process the change of state. Signed-off-by: Jisheng Zhang --- drivers/mmc/host/sdhci.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 63bc33a54d0d..b6c5021a5892 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2777,6 +2777,16 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id) return result; } +static irqreturn_t sdhci_cd_irq(int irq, void *dev_id) +{ + struct mmc_host *mmc = dev_id; + struct sdhci_host *host = mmc_priv(mmc); + + mmc->ops->card_event(mmc); + mmc_detect_change(host->mmc, msecs_to_jiffies(200)); + return IRQ_HANDLED; +} + static irqreturn_t sdhci_thread_irq(int irq, void *dev_id) { struct sdhci_host *host = dev_id; @@ -3617,6 +3627,8 @@ int __sdhci_add_host(struct sdhci_host *host) sdhci_init(host, 0); + mmc_gpio_set_cd_isr(mmc, sdhci_cd_irq); + ret = request_threaded_irq(host->irq, sdhci_irq, sdhci_thread_irq, IRQF_SHARED, mmc_hostname(mmc), host); if (ret) {