From patchwork Wed Aug 2 20:13:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9877495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C1A86602BC for ; Wed, 2 Aug 2017 20:13:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B39DD2874E for ; Wed, 2 Aug 2017 20:13:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A89032876A; Wed, 2 Aug 2017 20:13:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61B272874E for ; Wed, 2 Aug 2017 20:13:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753216AbdHBUNU (ORCPT ); Wed, 2 Aug 2017 16:13:20 -0400 Received: from sauhun.de ([88.99.104.3]:34253 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752766AbdHBUNT (ORCPT ); Wed, 2 Aug 2017 16:13:19 -0400 Received: from localhost (p54B337D1.dip0.t-ipconnect.de [84.179.55.209]) by pokefinder.org (Postfix) with ESMTPSA id C9AA42C2F41; Wed, 2 Aug 2017 22:13:16 +0200 (CEST) From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: linux-mmc@vger.kernel.org, Simon Horman , Wolfram Sang Subject: [RFT] arm64: dts: renesas: salvator-common: enable SDR104 for SD cards Date: Wed, 2 Aug 2017 22:13:11 +0200 Message-Id: <20170802201311.1394-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Tests showed that SDHI driver problems have been solved and SDR104 works now reliably on both Salvator-X SD card slots, both with an R-Car H3 (r8a7795 ES1.0) and R-Car M3 (r8a7796 ES 1.0). So, finally, enable it. Signed-off-by: Wolfram Sang Tested-by: Simon Horman --- Awesome, awesome! For the last two days, I did various tests with my boards and SD cards and SDR104 worked absolutely reliably :D Even the problematic card I had works flawlessly. I couldn't trigger the known failures anymore. Although I tried, I can't point to a single patch which "fixed" the issue. It is the constant work on dealing with smaller issues which makes SDR104 work at the end of the day. However, two patches are likely a bigger part of the cake: 43b0b361b01700 ("mmc: tmio: always get number of taps") -> Already upstream. This fixed retuning on card changes. 85b81aa16ec4ed ("mmc: tmio: fix CMD12 (STOP) handling") -> In mmc/next. This allows to handle tuning errors gracefully and to retune. With the freshly submitted Gen3 DMA patches, we also get nice transfer speeds :) This patch is based on renesas-drivers/master as of today. A branch for testing can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/v8-sdr104 All patches needed for reliable SDR104 are already upstream or in mmc/next. The above branch only adds another patch to enable DMA on Gen3. It is not strictly needed, but very nice to have. I think it would be cool to get both patches into v4.14. Looking forward to other testers. Simon, do you have some time for this? Thanks and kind regards, a very happy Wolfram arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index a451996f590a51..18e2da9f866684 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -569,6 +569,7 @@ wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; bus-width = <4>; sd-uhs-sdr50; + sd-uhs-sdr104; status = "okay"; }; @@ -597,6 +598,7 @@ wp-gpios = <&gpio4 16 GPIO_ACTIVE_HIGH>; bus-width = <4>; sd-uhs-sdr50; + sd-uhs-sdr104; status = "okay"; };