From patchwork Mon Aug 21 16:03:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 9913171 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9508F602A0 for ; Mon, 21 Aug 2017 16:05:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8682E2877E for ; Mon, 21 Aug 2017 16:05:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B322287B7; Mon, 21 Aug 2017 16:05:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 196A82877E for ; Mon, 21 Aug 2017 16:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754519AbdHUQD5 (ORCPT ); Mon, 21 Aug 2017 12:03:57 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:38339 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754477AbdHUQDX (ORCPT ); Mon, 21 Aug 2017 12:03:23 -0400 Received: by mail-wr0-f181.google.com with SMTP id p8so39043341wrf.5 for ; Mon, 21 Aug 2017 09:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pwhGKSiatDZIKAM4wyfDOdqR/aXoik20ct+gofTiRgA=; b=EsWmTVyuvmIMHotp0HOymvo8BAP5O4W1UO41uPtTcd+0mXb3/kC+7jiR3yQSBsv0Vk GZkJnd2NFjh7v/HYaTXSuBO4jJpo0SFXQN1frY1lK4Hat/gZkZlzZIue5thkSrupEUJH NNWYqOtznnRD3ILLlZwdu/1p/MiLMEIX80qecy/tEmtc/oxlQzyvZ3UPZAbVbUToWu+M mDB7Mfawl4FGX9kB0cry7M6ve338jvMvA78Zv2LzIHBWj17pPQkswZqe63v8MT4nW2Gb pyyw/0sO7oi5qPM567oxQ2tVDkh3QuI7TwMYgYaRjkEXvWoQbXmXs0cAahr3uD2I4SI1 FXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pwhGKSiatDZIKAM4wyfDOdqR/aXoik20ct+gofTiRgA=; b=PgwaEXSCedUcopZGzvjRcDASjqJWiIfQ4mgVv8rU6skbPnUe4lTlgscgl2XUVt/Mgh Ka5yzMr4eOSjRQcOQc2u9MPSQBla9Ls7O10r16ryCiVf2dxp+qSWIVPHFlt+816YudI7 pH/pNQpCzgQPxwTWKA1h029PUVdOblzBxXtCjvIw0z8DRBmJ5c2VMXRhls8uGxZOxWZT v26fsbjlExjJFum4ALhEFgcL7OlgCyhJjSv4T0eWyn/mJZoFuvlwMnn6rhFG2N+jH50T Js3NqKqPBMvYttAWDhK+ty7H1Yplb4wSjFZaGR7eGnleuX0wc53jEXmoupeqC2PM2QVJ vVxg== X-Gm-Message-State: AHYfb5g75k8PjZZhpXGuipGA4wud/s28BKknC7x31uSFPkFq+pi/4M50 Do3WuuvoMZ0MHo/et3A= X-Received: by 10.28.161.196 with SMTP id k187mr1898796wme.118.1503331401515; Mon, 21 Aug 2017 09:03:21 -0700 (PDT) Received: from localhost.localdomain ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id 63sm8120063wra.30.2017.08.21.09.03.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Aug 2017 09:03:21 -0700 (PDT) From: Jerome Brunet To: Ulf Hansson , Kevin Hilman , Carlo Caione Cc: Jerome Brunet , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 15/16] mmc: meson-gx: change default tx phase Date: Mon, 21 Aug 2017 18:03:00 +0200 Message-Id: <20170821160301.21899-16-jbrunet@baylibre.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170821160301.21899-1-jbrunet@baylibre.com> References: <20170821160301.21899-1-jbrunet@baylibre.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initial default tx phase was set to 0 while the datasheet recommends 270. Some cards fails to initialize with this setting and eMMC mode DDR52 does not work. Changing this setting to 270 fixes these issues, without any regression so far Signed-off-by: Jerome Brunet Reviewed-by: Kevin Hilman --- drivers/mmc/host/meson-gx-mmc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 3167f561e1a6..290631d46a4b 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1158,8 +1158,14 @@ static int meson_mmc_probe(struct platform_device *pdev) if (ret) goto free_host; + /* + * Set phases : These values are mostly the datasheet recommended ones + * except for the Tx phase. Datasheet recommends 180 but some cards + * fail at initialisation with it. 270 works just fine, it fixes these + * initialisation issues and enable eMMC DDR52 mode. + */ host->tp.core_phase = 180; - host->tp.tx_phase = 0; + host->tp.tx_phase = 270; host->tp.rx_phase = 0; ret = meson_mmc_clk_init(host);