From patchwork Thu Sep 21 05:42:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangbo Lu X-Patchwork-Id: 9963283 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 40F5F6056A for ; Thu, 21 Sep 2017 06:00:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3332C29374 for ; Thu, 21 Sep 2017 06:00:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2170629376; Thu, 21 Sep 2017 06:00:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C83F2937A for ; Thu, 21 Sep 2017 06:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663AbdIUGAE (ORCPT ); Thu, 21 Sep 2017 02:00:04 -0400 Received: from mail-by2nam01on0068.outbound.protection.outlook.com ([104.47.34.68]:33504 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751641AbdIUGAD (ORCPT ); Thu, 21 Sep 2017 02:00:03 -0400 Received: from BN6PR03CA0059.namprd03.prod.outlook.com (10.173.137.21) by BN3PR03MB2356.namprd03.prod.outlook.com (10.166.74.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 21 Sep 2017 06:00:01 +0000 Received: from BN1BFFO11FD021.protection.gbl (2a01:111:f400:7c10::1:155) by BN6PR03CA0059.outlook.office365.com (2603:10b6:404:4c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.9 via Frontend Transport; Thu, 21 Sep 2017 06:00:01 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD021.mail.protection.outlook.com (10.58.144.84) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.35.14 via Frontend Transport; Thu, 21 Sep 2017 06:00:01 +0000 Received: from titan.ap.freescale.net ([10.192.208.233]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8L5xwVk025213; Wed, 20 Sep 2017 22:59:59 -0700 From: Yangbo Lu To: , , Adrian Hunter CC: Yangbo Lu Subject: [PATCH] mmc: sdhci-of-esdhc: disable SD clock for clock value 0 Date: Thu, 21 Sep 2017 13:42:38 +0800 Message-ID: <20170921054238.46666-1-yangbo.lu@nxp.com> X-Mailer: git-send-email 2.14.1 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131504472020428240; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(346002)(39380400002)(376002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(106466001)(33646002)(105606002)(1076002)(77096006)(5660300001)(97736004)(4326008)(47776003)(53936002)(86362001)(6666003)(85426001)(189998001)(50226002)(48376002)(50466002)(498600001)(50986999)(110136005)(16586007)(316002)(2906002)(230783001)(305945005)(68736007)(104016004)(356003)(8936002)(36756003)(81166006)(81156014)(8656003)(5003940100001)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2356; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD021; 1:ju5q2o0HChhxrg6uzWIsK6sriCz0jli+a/QbD9qvCosH5w+a0Lt9MormOOpFIOX3GCONmtIMlB4vR+UONpCJVJus8PKkMCAweiNnNM85qsljBAA0pqlRE1/t6oVcPFBd MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 96a17521-4e2e-453a-c46f-08d500b5ff9b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN3PR03MB2356; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2356; 3:bcpjGnxVEELn0Yb6SFkGeJ+P8ezM5QBPvCRvNmyTlzxj6xgCcvznMOzQrEPOLgpruSGQQ+kpc0Av8ffrAr3aGbtetJtkO3zxk9GLjuhG1Q+W8jTNvJxRAULLjhQRgW0SbiARLs0BvHXWJg/C01Lsr34NwQ8nTS0eC29gWoWpbkjYapOAisXGpsMj/zylcOW62WX+lac9TMpzha+9zJtFrLvwZQyBqcHC4+z3cajnarqHvqViGz2hHRDwUDZeyMtJ6tkKxpS8vjUoSfh4r+RbjeGuSlhBwWuUj1fE0MwfQGCEpFfoeu47OCXnIB02jN8PgSHDoGVVrLIGEz3UYtr0bLYnv9V7r62TtT3GsT+/ZkQ=; 25:7gyY8T/d9XSMYCofCz1PDm7Yjklknq+WZll7SO8bKjmEt/p1fbJd7S0OVRmDtKNXM0RJatPN/6lzZDGVa68SwpKxhhla1RCH3CINQJBfRBt0qQaw+WBZG/LzaGVIw5pscBKuSewNs7ioSaqXhlElLmX34mBEngBC1krbklvYhI5FJVK7WBvQewyRmC3EPl3jAC3jz/T3p8EbE/ygttpTEXtJ5ivSS5TCPw+S5Gpot7tBgsYxm0WY+c0x09pnXZeiJI5JfhRIjoR3Y57prePuBqFfltc9D0fQAvYGfmp3wU9V1xh1nX3YUDEKIWtq6rsFnfMpE9TnhLd41FfFy0rETg== X-MS-TrafficTypeDiagnostic: BN3PR03MB2356: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2356; 31:RuQ1ZNeGAtV7M7/QMNEHkw+kvrzuoDhse1z2D7KdlEiZIFf68T/krj092FxFseMdcogVNe4FFH3u9oFoA6mjqndrQg5RqSZ7YD6vSCjLYnjsQdnQ11DCBu7meBAFvAHXUOvWs3K1i5mEaKycf6bOjbd02YxJunAmMfjb/LCYrIKaVBl/gxabLuq+7igD4bh5i2219VqTbBRXzVUPjWUFiTYUyAbvOSfo9JdvNSWcN4Y=; 4:zwIf1iBt/mvZ16NOnOCvfVUp5TgWuuihAdZc9VuEUdDc6mR005HbVC6BfW6lgItWp+9PgArtOVOkeOwqNth8ykJI1l5Da3IIdYPSJLvl1CQI2FPsNWYVf1heckOF+M99H1dTZVvfRlbmmPBB0FndbZ0UapRzUh2LC7Zuza+FlQD9Xh36+O1OHUdOVCNf7C1SW47TB+C6K0VIqGz0OWheN2HIuuTqjJe+dLjFLOZ1JrA2cmSPPE68NTENR17i3J5Ow6DaysmlXVv3O9IwQdfuvbf7mfUFP+1NCze8LWj/Ep4= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6096035)(20161123565025)(20161123563025)(20161123561025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123559100)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2356; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2356; X-Forefront-PRVS: 04371797A5 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR03MB2356; 23:zhXWDWCoF4FwHbRbvFtCmf7MJNrfFrwuc7w0w51p5?= =?us-ascii?Q?nvcyMpEprwwC9ur1NpD2wv8uny/U3XieLqV4R6tMEH7tz+zZaLTv8fUycFyt?= =?us-ascii?Q?s8shlkNpIM3D+Y5D+qQyDP/exSLoeqwVIs6VHKxd8n76FXHD26rb6WN/eFyK?= =?us-ascii?Q?+sE/OpQiQfMlY7gNHaLK7+o9SBQOvcPIKpmZVgk9pUlIXqtt0+GoGfWWGVfe?= =?us-ascii?Q?3qVTp1RtC2mebch4zxTUZ1uM4pRTiWMeqgpkGbRSVMieGuQuPS5kT6HBK4bh?= =?us-ascii?Q?c2uy0ANem3xcTkJ9YkHQ9eGodPRb/aXLwHHP23htDiUyWWjlkdF8liVsKKst?= =?us-ascii?Q?/e1dbk/jQKwCpRHvpw+dmLOyWmlre8gXLARcX8inOBEB4o9FAc85vD3hzSUe?= =?us-ascii?Q?lZ1PVNGXcBFHOoGpOxD/7HDQKMMy+QTQhxW3zf66jUmICC8TWIUJEZDsIU3J?= =?us-ascii?Q?y/ZxQ2wuhk9NwgHaQQc3ACgRyKDsXC6JSD1nb0zpZr04JiKLNlZ+TbOTK2rb?= =?us-ascii?Q?08n8SmIGyEXdiM6wU5PvF4YcB9CB/ojojWhUm0yF2syH4q3oZOU8/0gq0IbS?= =?us-ascii?Q?hDuYm8Pt5kalLN5h8wU7DheU85UUAINuGejq4lH3mQ5JyvUnVHZ+9mQzIb2x?= =?us-ascii?Q?TtECyJ+TnHZXVnVom3Bh2m2eU0dFGQlUnU2YZDnGs2ZplAwHm6SoJnyAl+Hc?= =?us-ascii?Q?lWHF6GPkFMmHgooIoloODxEBsHJElcR1qATC3xJ4M+BBBJNa3qAQZIutq/HP?= =?us-ascii?Q?EQgUJSesr2SbFE75VoIRUXpCfv54Bf31w99vocJCLFnbA2MJmAal3iWcb4xW?= =?us-ascii?Q?FadUjx3rP+LKyWSPBFpVGHh49p920ouqFwoH+blZikagTxJv9eAUJyCNyZni?= =?us-ascii?Q?q3rSFdJRqolrf9IR02pGig9xkTCh7VrUH7+Z3lhMjCcxkBCmmVVFcKMG/iIi?= =?us-ascii?Q?7UgEQG12fAYz185NOErQx9wLShz9MO994p+5Ptf0vPcYEKuULG+cZdmofKK/?= =?us-ascii?Q?mG/lN/vr9Ge53O9BdS8jtJmmzSTaficdgJSJ80ZPat4ew2QFscZAZcDvASGe?= =?us-ascii?Q?CHO+XA50NgoWVySv1xqerrccC/wMs8NWCMa2s3BOn59SXj0/jd+D8f/sdl6X?= =?us-ascii?Q?fXpEVa9Ez429+UiD1LpLtxQil6yZQLu?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2356; 6:24G+m46/tURTcfd7okhK7/aTJMt4q5DUxxuza9D7AjG5ITunVf7YhUIFTVYmjyzaRzBm+vq2Qqjx19EYCVlwSXVoedX0v7qSIojL4Fv5atpPhs8e0Y2N2b+qEhJWmQ1gXqdsFRXkyUFpjP3w33xH7Zb//gjxaryJEBSVpCrNLYIDFhg9bMZZedfFF6GkgJ+aB1v6lIPBwWvOZgf47cy0CC7yJtRh+aK3BebvUvbpd7ZH0F9CVyBW8aoYf/PLOIDMF07T7C5yWhTEtp4UHVCOo72hyyGdQG8YE76juWHLw3BBk/aIXz2Xm01e+f6YRfB6b3W2qGVE4CbotBb/WvrQCA==; 5:VysLchDRHOBv//nXpq2rstyHeJwSNZzLjrjSXp0aDqSqM9NSpk0x/Xj3gwDrNMyR6KB8gB+tmQwgaptiNGp+btqXKVXgJwDbwHY6bfWvbETWU7TLA5aOkpRccv4tb578VlSlPCmV1JAYjdPtdh4uGQ==; 24:R4MDtBqL/yduz8Aic6iPFWCKHtpQwvHXiqbWMCH5ygdmcrkOGnQ675pxEbKXMW4W6gkr9S7pQgGkzoVXpJ8p7Y4qjT+kvDQr+kAn3WYUoQc=; 7:3NvYdnS4w535WkbVWHa/thez2P4uFHiFRPRquXIjXMlfU8WNA28DEA3p8CIyIxPPPOHiDkGwInh1phkEYgsLTLiiZorQ8fPqgn4Rvf7oE9DFD9KSw06LXY9x/eL3N7q8IlDGavPI509FENeFiPqMyW3LmPT5kpv6jwy5yoGapX9qvDi45fPjNCFMnZHQbme3fMM0tHV58geMoZvt3tOWgCqLtKcRR7mTA9F+kOCWNXs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2017 06:00:01.8556 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2356 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP SD clock should be disabled for clock value 0. It's not right to just return. This may cause failure of signal voltage switching. Signed-off-by: Yangbo Lu Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-esdhc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index d96a057a7db8..b21008729aeb 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -36,6 +36,8 @@ struct sdhci_esdhc { unsigned int peripheral_clock; }; +static void esdhc_clock_enable(struct sdhci_host *host, bool enable); + /** * esdhc_read*_fixup - Fixup the value read from incompatible eSDHC register * to make it compatible with SD spec. @@ -469,8 +471,10 @@ static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int clock) host->mmc->actual_clock = 0; - if (clock == 0) + if (clock == 0) { + esdhc_clock_enable(host, false); return; + } /* Workaround to start pre_div at 2 for VNN < VENDOR_V_23 */ if (esdhc->vendor_ver < VENDOR_V_23)