| Message ID | 20180629144738.446-7-daniel@zonque.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Daniel Mack <daniel@zonque.org> writes: > Devicetree-enabled boards should use proper regulators to control the > power of cards, not GPIOs, so let's remove this property. The regulator > properties are are supported by the MMC core and are described in the s/are are/are/ > Note that devicetree support for PXA platforms hasn't fully landed yet, > so this binding does not have any users at this point. No users in-tree to be more specific. > diff --git a/Documentation/devicetree/bindings/mmc/pxa-mmc.txt b/Documentation/devicetree/bindings/mmc/pxa-mmc.txt > index b7025de7dced..359b13977f24 100644 > --- a/Documentation/devicetree/bindings/mmc/pxa-mmc.txt > +++ b/Documentation/devicetree/bindings/mmc/pxa-mmc.txt > @@ -8,7 +8,6 @@ Required properties: > > Optional properties: > - marvell,detect-delay-ms: sets the detection delay timeout in ms. > -- marvell,gpio-power: GPIO spec for the card power enable pin Okay, I don't have a big devicetree knowledge, but wouldn't it make sense to augment the example in this file to show the proper usage of card power (and at it wp-gpio and cd-gpio) ? Cheers.
diff --git a/Documentation/devicetree/bindings/mmc/pxa-mmc.txt b/Documentation/devicetree/bindings/mmc/pxa-mmc.txt index b7025de7dced..359b13977f24 100644 --- a/Documentation/devicetree/bindings/mmc/pxa-mmc.txt +++ b/Documentation/devicetree/bindings/mmc/pxa-mmc.txt @@ -8,7 +8,6 @@ Required properties: Optional properties: - marvell,detect-delay-ms: sets the detection delay timeout in ms. -- marvell,gpio-power: GPIO spec for the card power enable pin This file documents differences between the core properties in mmc.txt and the properties used by the pxa-mmc driver. diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index e15708aa77a2..c01d69904e2a 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -612,9 +612,6 @@ static int pxamci_of_init(struct platform_device *pdev, of_get_named_gpio(np, "wp-gpios", 0); /* pxa-mmc specific */ - pdata->gpio_power = - of_get_named_gpio(np, "pxa-mmc,gpio-power", 0); - if (of_property_read_u32(np, "pxa-mmc,detect-delay-ms", &tmp) == 0) pdata->detect_delay_ms = tmp;
Devicetree-enabled boards should use proper regulators to control the power of cards, not GPIOs, so let's remove this property. The regulator properties are are supported by the MMC core and are described in the generic MMC document: Documentation/devicetree/bindings/mmc/mmc.txt Note that devicetree support for PXA platforms hasn't fully landed yet, so this binding does not have any users at this point. Signed-off-by: Daniel Mack <daniel@zonque.org> --- Documentation/devicetree/bindings/mmc/pxa-mmc.txt | 1 - drivers/mmc/host/pxamci.c | 3 --- 2 files changed, 4 deletions(-)