From patchwork Sat Dec 29 12:57:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 10744833 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6609091E for ; Sat, 29 Dec 2018 12:57:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56E9A289EA for ; Sat, 29 Dec 2018 12:57:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4AD3328A3C; Sat, 29 Dec 2018 12:57:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E83C289F3 for ; Sat, 29 Dec 2018 12:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726050AbeL2M5g (ORCPT ); Sat, 29 Dec 2018 07:57:36 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38744 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726032AbeL2M5g (ORCPT ); Sat, 29 Dec 2018 07:57:36 -0500 Received: by mail-wm1-f67.google.com with SMTP id m22so21619996wml.3; Sat, 29 Dec 2018 04:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xIicdGAZhx3oX8Do8U6owJozuwFheS9BvjevYH1ytJA=; b=vSUJsCZJay6P1s9+cUUsg4EyQY9B6g4wPoUkRr8ugPyFd3BGS7dx8WDQOHQvZTJeKJ dUTXEIadRwkCclQbLgGyaYVodzD+2fQE12cyRzh7sNQ6ud2O1TyrnO6yYqGS+GzYv5hR seYqOs5MAMtjG7Ltrqy5DkmNkRONLjnVWAp8Fx1cUow2JaSlRZNK66CUiTtb1OR0h4Ne D3lARx2Hp3r2b4Ib3diJs5ckbOayVD94K7QHwjZt4Le2IyNFrE8utt8YNY4gIh6bZ6mN 9HkhTH7Cc/AggtlefXDjnlZd7s4KU2ld+/Vw0KaPDlWZRiE/GToc+LBvjW9kKC+pwV/P xvpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xIicdGAZhx3oX8Do8U6owJozuwFheS9BvjevYH1ytJA=; b=FI9kMQGGRes8TMXTff06F3EpkbgL6ck6r6jZnzdFx3vY3mBLfj9cV7O+kV/AVbsetb LVd/r8KeTxwq8Mln3LpHDvKAOC1CatjfkazxfP5gi/mCBczPK/tCaNVyXTDFYTgkqJJC 1eWTPnaSgmiH2Hb4C31Xl0nEhqC3MCOUgup4D04EQBpN5kNpztV83MD7nZGfBHxdTs7E is/2QUiPtCFStjPiFT01CHrlZUd/b7gTR5KxLIQ7lvBFT06RpQ2wuFlXuad74EkxV8Pp YKkusw9aa++45mF4Ly6UHYJvIGHbs6VbbN5Fq+RFC2XwoCDaWay6p8KRcXPFlglSbIV5 Up5w== X-Gm-Message-State: AJcUukcaE6CHXwuRawfdj9YrDzIKZBe1K85SdWP/vBIHzHDYmz+QfVpx KpQeHJmJLQFWtN2RX+mJ4bE= X-Google-Smtp-Source: ALg8bN5/l9t6q0dLNUkjDZUDqscN0lPtglIgBb1+hFQqy60FkUOIXZDXWxyVoBbpJYIP5/WaH2GCWA== X-Received: by 2002:a1c:1a43:: with SMTP id a64mr25464631wma.136.1546088254367; Sat, 29 Dec 2018 04:57:34 -0800 (PST) Received: from blackbox.darklights.net (p200300DCD7294600914F24DE1716D3FC.dip0.t-ipconnect.de. [2003:dc:d729:4600:914f:24de:1716:d3fc]) by smtp.googlemail.com with ESMTPSA id h17sm31987059wrt.59.2018.12.29.04.57.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Dec 2018 04:57:33 -0800 (PST) From: Martin Blumenstingl To: linux-amlogic@lists.infradead.org, khilman@baylibre.com, linus.walleij@linaro.org Cc: linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linus.luessing@c0d3.blue, balbes-150@yandex.ru, linux@roeck-us.net, bgolaszewski@baylibre.com, Martin Blumenstingl Subject: [PATCH 1/3] ARM: dts: meson8b: odroidc1: mark the SD card detection GPIO active-low Date: Sat, 29 Dec 2018 13:57:09 +0100 Message-Id: <20181229125711.5205-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> References: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device tree") SD cards are not detected anymore. The CD GPIO is "active low" on Odroid-C1. The MMC dt-bindings specify: "[...] using the "cd-inverted" property means, that the CD line is active high, i.e. it is high, when a card is inserted". Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and drop the "cd-inverted" property. This makes the definition consistent with the existing dt-bindings and fixes the check whether an SD card is inserted. Fixes: e03efbce6bebf5 ("ARM: dts: meson8b-odroidc1: add microSD support") Signed-off-by: Martin Blumenstingl Reviewed-by: Linus Walleij Tested-by: Anand Moon --- arch/arm/boot/dts/meson8b-odroidc1.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index 58669abda259..070d69889f3e 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -273,8 +273,7 @@ cap-sd-highspeed; disable-wp; - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; - cd-inverted; + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>; vmmc-supply = <&tflash_vdd>; vqmmc-supply = <&tf_io>;