From patchwork Sat Dec 29 12:57:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 10744835 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B2AED14DE for ; Sat, 29 Dec 2018 12:57:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A4124289EA for ; Sat, 29 Dec 2018 12:57:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 980CB28A3C; Sat, 29 Dec 2018 12:57:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EF2A28A1D for ; Sat, 29 Dec 2018 12:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbeL2M5i (ORCPT ); Sat, 29 Dec 2018 07:57:38 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34924 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbeL2M5h (ORCPT ); Sat, 29 Dec 2018 07:57:37 -0500 Received: by mail-wr1-f68.google.com with SMTP id 96so23087510wrb.2; Sat, 29 Dec 2018 04:57:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VlAqZUJKjhpDiruDFrlNjds26NWgcPdIHOc9gfNOZDw=; b=YWvhDm0AIwD9W5CR4hxwB9wQM2KP/7L0i9j7aD1eEFABQNrP8Svf0auI8t44vA4Aj7 u76e+fiMzYUvNuMG0Fb0p5GOm354hoN4/zjkDLwxQSkn+3zJXi3jgCFmPRhuG6fiDAtW IfEAQANGeMa5jWqjUTH7DhnF0Illwl6a0um15uy7ZmnuFZNFv0EepJPqfZroo5P23dYs UfUBbuqEfNSLLGAzqTdb2FOMOHOHGPtG/v1jiAyJ6t1+Bh/p1aq6q9EvcJkGSWJQqXyM bEkUfKYbiKB19Syc1Ppueb1YgnG6A0k36hgg4cN3fWbeKl4IGkv/jCiCell9LQqEHFzc aEPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VlAqZUJKjhpDiruDFrlNjds26NWgcPdIHOc9gfNOZDw=; b=S2J1YlMQnGV7DPSJ9Ff/06jdBuh+HbJfg4FofuFswF6rktZBKDZWgzfiAFrkhzoYY0 CanKxKxUkuuFspulmWZEfDvcHtek2lJTKPLPsehPsN2SB3ufbpPbCQqZQox9FNCH9YoT Cx6upQSb5N7gqspoeGXIloS7C3GvnqLoIbbb/YHr2ctj19DusXEmEwV4xR/HR2v/f0fk DwQuoqpGNaV7G2P9vX+S15NCIPudwPZVmdTCU1pJS8a2DadeWwesd8E9vHla+6W69YmO GW2AsJ94xEYwCAu8KAOtYeIIpR4geb3QCLQF4U4mG2ikKgygPn7MykUV+7srWt+CLmMe MXNg== X-Gm-Message-State: AJcUukd6ek3ccLQHDq/YjhicUiYJuQsy44U0vp8UT3fP6wIunG/KrHcr 13OAyXv98mdX+VHJgKXYkkk= X-Google-Smtp-Source: ALg8bN7xzdiR3LRxK+u6K8d/bbdwUQJ88L0TyNFqvdygQEPhOt8U5L8VvlqqHSd8UJjMYifFUIQMSA== X-Received: by 2002:adf:a743:: with SMTP id e3mr27143292wrd.56.1546088255653; Sat, 29 Dec 2018 04:57:35 -0800 (PST) Received: from blackbox.darklights.net (p200300DCD7294600914F24DE1716D3FC.dip0.t-ipconnect.de. [2003:dc:d729:4600:914f:24de:1716:d3fc]) by smtp.googlemail.com with ESMTPSA id h17sm31987059wrt.59.2018.12.29.04.57.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Dec 2018 04:57:34 -0800 (PST) From: Martin Blumenstingl To: linux-amlogic@lists.infradead.org, khilman@baylibre.com, linus.walleij@linaro.org Cc: linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linus.luessing@c0d3.blue, balbes-150@yandex.ru, linux@roeck-us.net, bgolaszewski@baylibre.com, Martin Blumenstingl Subject: [PATCH 2/3] ARM: dts: meson8b: ec100: mark the SD card detection GPIO active-low Date: Sat, 29 Dec 2018 13:57:10 +0100 Message-Id: <20181229125711.5205-3-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> References: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device tree") SD cards are not detected anymore. The CD GPIO is "active low" on the EC-100. The MMC dt-bindings specify: "[...] using the "cd-inverted" property means, that the CD line is active high, i.e. it is high, when a card is inserted". Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and drop the "cd-inverted" property. This makes the definition consistent with the existing dt-bindings and fixes the check whether an SD card is inserted. Fixes: bbedc1f1d90e33 ("ARM: dts: meson8b: Add support for the Endless Mini (EC-100)") Signed-off-by: Martin Blumenstingl Reviewed-by: Linus Walleij --- arch/arm/boot/dts/meson8b-ec100.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/meson8b-ec100.dts b/arch/arm/boot/dts/meson8b-ec100.dts index 0872f6e3abf5..d50fc2f60fa3 100644 --- a/arch/arm/boot/dts/meson8b-ec100.dts +++ b/arch/arm/boot/dts/meson8b-ec100.dts @@ -205,8 +205,7 @@ cap-sd-highspeed; disable-wp; - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; - cd-inverted; + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>; vmmc-supply = <&vcc_3v3>; };