| Message ID | 20200302093534.9055-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: renesas_sdhi: Use BITS_PER_LONG helper | expand |
Hi Geert, Thanks for your work. On 2020-03-02 10:35:34 +0100, Geert Uytterhoeven wrote: > Use the existing BITS_PER_LONG helper definition instead of calculating > this value. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/mmc/host/renesas_sdhi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h > index 7a1a741547f25de5..2a4c83a5f32ef8e2 100644 > --- a/drivers/mmc/host/renesas_sdhi.h > +++ b/drivers/mmc/host/renesas_sdhi.h > @@ -60,7 +60,7 @@ struct renesas_sdhi { > bool doing_tune; > > /* Tuning values: 1 for success, 0 for failure */ > - DECLARE_BITMAP(taps, BITS_PER_BYTE * sizeof(long)); > + DECLARE_BITMAP(taps, BITS_PER_LONG); > unsigned int tap_num; > unsigned long tap_set; > }; > -- > 2.17.1 >
On Tue, Mar 03, 2020 at 01:48:42PM +0100, Niklas Söderlund wrote: > Hi Geert, > > Thanks for your work. > > On 2020-03-02 10:35:34 +0100, Geert Uytterhoeven wrote: > > Use the existing BITS_PER_LONG helper definition instead of calculating > > this value. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Mon, 2 Mar 2020 at 10:35, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > Use the existing BITS_PER_LONG helper definition instead of calculating > this value. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/renesas_sdhi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h > index 7a1a741547f25de5..2a4c83a5f32ef8e2 100644 > --- a/drivers/mmc/host/renesas_sdhi.h > +++ b/drivers/mmc/host/renesas_sdhi.h > @@ -60,7 +60,7 @@ struct renesas_sdhi { > bool doing_tune; > > /* Tuning values: 1 for success, 0 for failure */ > - DECLARE_BITMAP(taps, BITS_PER_BYTE * sizeof(long)); > + DECLARE_BITMAP(taps, BITS_PER_LONG); > unsigned int tap_num; > unsigned long tap_set; > }; > -- > 2.17.1 >
diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h index 7a1a741547f25de5..2a4c83a5f32ef8e2 100644 --- a/drivers/mmc/host/renesas_sdhi.h +++ b/drivers/mmc/host/renesas_sdhi.h @@ -60,7 +60,7 @@ struct renesas_sdhi { bool doing_tune; /* Tuning values: 1 for success, 0 for failure */ - DECLARE_BITMAP(taps, BITS_PER_BYTE * sizeof(long)); + DECLARE_BITMAP(taps, BITS_PER_LONG); unsigned int tap_num; unsigned long tap_set; };
Use the existing BITS_PER_LONG helper definition instead of calculating this value. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/mmc/host/renesas_sdhi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)