Message ID | 20200408142252.21958-1-wsa+renesas@sang-engineering.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | mmc: renesas_sdhi: simplify summary output | expand |
Hi Wolfram, Thanks for your work. On 2020-04-08 16:22:52 +0200, Wolfram Sang wrote: > No need to call platform_get_resource twice when we still have the > pointer from before. Also, use '%pa' for a resource_size_t pointer. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/mmc/host/renesas_sdhi_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index c002e9fb67fb..de7f4fc9bc21 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -933,10 +933,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, > goto eirq; > } > > - dev_info(&pdev->dev, "%s base at 0x%08lx max clock rate %u MHz\n", > - mmc_hostname(host->mmc), (unsigned long) > - (platform_get_resource(pdev, IORESOURCE_MEM, 0)->start), > - host->mmc->f_max / 1000000); > + dev_info(&pdev->dev, "%s base at %pa, max clock rate %u MHz\n", > + mmc_hostname(host->mmc), &res->start, host->mmc->f_max / 1000000); > > return ret; > > -- > 2.20.1 >
On Wed, 8 Apr 2020 at 16:25, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > No need to call platform_get_resource twice when we still have the > pointer from before. Also, use '%pa' for a resource_size_t pointer. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/renesas_sdhi_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index c002e9fb67fb..de7f4fc9bc21 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -933,10 +933,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, > goto eirq; > } > > - dev_info(&pdev->dev, "%s base at 0x%08lx max clock rate %u MHz\n", > - mmc_hostname(host->mmc), (unsigned long) > - (platform_get_resource(pdev, IORESOURCE_MEM, 0)->start), > - host->mmc->f_max / 1000000); > + dev_info(&pdev->dev, "%s base at %pa, max clock rate %u MHz\n", > + mmc_hostname(host->mmc), &res->start, host->mmc->f_max / 1000000); > > return ret; > > -- > 2.20.1 >
On Wed, Apr 8, 2020 at 5:17 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > No need to call platform_get_resource twice when we still have the > pointer from before. Also, use '%pa' for a resource_size_t pointer. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index c002e9fb67fb..de7f4fc9bc21 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -933,10 +933,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, goto eirq; } - dev_info(&pdev->dev, "%s base at 0x%08lx max clock rate %u MHz\n", - mmc_hostname(host->mmc), (unsigned long) - (platform_get_resource(pdev, IORESOURCE_MEM, 0)->start), - host->mmc->f_max / 1000000); + dev_info(&pdev->dev, "%s base at %pa, max clock rate %u MHz\n", + mmc_hostname(host->mmc), &res->start, host->mmc->f_max / 1000000); return ret;
No need to call platform_get_resource twice when we still have the pointer from before. Also, use '%pa' for a resource_size_t pointer. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/mmc/host/renesas_sdhi_core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)