| Message ID | 20200420170230.9091-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: renesas_sdhi: shorten types after refactorization | expand |
Hi Wolfram, Thanks for your patch. On 2020-04-20 19:02:30 +0200, Wolfram Sang wrote: > After TAP refactorization, we can use 'unsigned int' for two more > variables because all the calculations work on this type now. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/mmc/host/renesas_sdhi.h | 2 +- > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h > index 12d8016672b0..86efa9d5cd6d 100644 > --- a/drivers/mmc/host/renesas_sdhi.h > +++ b/drivers/mmc/host/renesas_sdhi.h > @@ -64,7 +64,7 @@ struct renesas_sdhi { > /* Sampling data comparison: 1 for match, 0 for mismatch */ > DECLARE_BITMAP(smpcmp, BITS_PER_LONG); > unsigned int tap_num; > - unsigned long tap_set; > + unsigned int tap_set; > }; > > #define host_to_priv(host) \ > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index 1dfe6c32280b..28b0830c4251 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -527,7 +527,7 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode) > static bool renesas_sdhi_manual_correction(struct tmio_mmc_host *host, bool use_4tap) > { > struct renesas_sdhi *priv = host_to_priv(host); > - unsigned long new_tap = priv->tap_set; > + unsigned int new_tap = priv->tap_set; > u32 val; > > val = sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ); > -- > 2.20.1 >
On Mon, 20 Apr 2020 at 19:02, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > After TAP refactorization, we can use 'unsigned int' for two more > variables because all the calculations work on this type now. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/renesas_sdhi.h | 2 +- > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h > index 12d8016672b0..86efa9d5cd6d 100644 > --- a/drivers/mmc/host/renesas_sdhi.h > +++ b/drivers/mmc/host/renesas_sdhi.h > @@ -64,7 +64,7 @@ struct renesas_sdhi { > /* Sampling data comparison: 1 for match, 0 for mismatch */ > DECLARE_BITMAP(smpcmp, BITS_PER_LONG); > unsigned int tap_num; > - unsigned long tap_set; > + unsigned int tap_set; > }; > > #define host_to_priv(host) \ > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index 1dfe6c32280b..28b0830c4251 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -527,7 +527,7 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode) > static bool renesas_sdhi_manual_correction(struct tmio_mmc_host *host, bool use_4tap) > { > struct renesas_sdhi *priv = host_to_priv(host); > - unsigned long new_tap = priv->tap_set; > + unsigned int new_tap = priv->tap_set; > u32 val; > > val = sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ); > -- > 2.20.1 >
diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h index 12d8016672b0..86efa9d5cd6d 100644 --- a/drivers/mmc/host/renesas_sdhi.h +++ b/drivers/mmc/host/renesas_sdhi.h @@ -64,7 +64,7 @@ struct renesas_sdhi { /* Sampling data comparison: 1 for match, 0 for mismatch */ DECLARE_BITMAP(smpcmp, BITS_PER_LONG); unsigned int tap_num; - unsigned long tap_set; + unsigned int tap_set; }; #define host_to_priv(host) \ diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index 1dfe6c32280b..28b0830c4251 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -527,7 +527,7 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode) static bool renesas_sdhi_manual_correction(struct tmio_mmc_host *host, bool use_4tap) { struct renesas_sdhi *priv = host_to_priv(host); - unsigned long new_tap = priv->tap_set; + unsigned int new_tap = priv->tap_set; u32 val; val = sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ);
After TAP refactorization, we can use 'unsigned int' for two more variables because all the calculations work on this type now. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/mmc/host/renesas_sdhi.h | 2 +- drivers/mmc/host/renesas_sdhi_core.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)