| Message ID | 20200821063533.3771-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: improve documentation of HW_RESET | expand |
On Fri, 21 Aug 2020 at 08:35, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > HW_RESET means resetting the remote device, not the controller. Two > drivers got it wrong, so make it more clear. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied for next, with a few amendments, thanks! Kind regards Uffe > --- > > I sent a series to fix the TMIO/SDHI driver. The other one is bcm2835, > but I want to get this patch approved, before I notify the maintainers. > > include/linux/mmc/host.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h > index c5b6e97cb21a..cf04793ab4ea 100644 > --- a/include/linux/mmc/host.h > +++ b/include/linux/mmc/host.h > @@ -163,6 +163,7 @@ struct mmc_host_ops { > int (*select_drive_strength)(struct mmc_card *card, > unsigned int max_dtr, int host_drv, > int card_drv, int *drv_type); > + /* Reset remote device via RST_n */ > void (*hw_reset)(struct mmc_host *host); > void (*card_event)(struct mmc_host *host); > > @@ -346,7 +347,7 @@ struct mmc_host { > #define MMC_CAP_CD_WAKE (1 << 28) /* Enable card detect wake */ > #define MMC_CAP_CMD_DURING_TFR (1 << 29) /* Commands during data transfer */ > #define MMC_CAP_CMD23 (1 << 30) /* CMD23 supported. */ > -#define MMC_CAP_HW_RESET (1 << 31) /* Hardware reset */ > +#define MMC_CAP_HW_RESET (1 << 31) /* supports device reset via RST_n */ > > u32 caps2; /* More host capabilities */ > > -- > 2.20.1 >
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index c5b6e97cb21a..cf04793ab4ea 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -163,6 +163,7 @@ struct mmc_host_ops { int (*select_drive_strength)(struct mmc_card *card, unsigned int max_dtr, int host_drv, int card_drv, int *drv_type); + /* Reset remote device via RST_n */ void (*hw_reset)(struct mmc_host *host); void (*card_event)(struct mmc_host *host); @@ -346,7 +347,7 @@ struct mmc_host { #define MMC_CAP_CD_WAKE (1 << 28) /* Enable card detect wake */ #define MMC_CAP_CMD_DURING_TFR (1 << 29) /* Commands during data transfer */ #define MMC_CAP_CMD23 (1 << 30) /* CMD23 supported. */ -#define MMC_CAP_HW_RESET (1 << 31) /* Hardware reset */ +#define MMC_CAP_HW_RESET (1 << 31) /* supports device reset via RST_n */ u32 caps2; /* More host capabilities */
HW_RESET means resetting the remote device, not the controller. Two drivers got it wrong, so make it more clear. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- I sent a series to fix the TMIO/SDHI driver. The other one is bcm2835, but I want to get this patch approved, before I notify the maintainers. include/linux/mmc/host.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)