| Message ID | 20210220142953.918608-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] mmc: uniphier-sd: Fix an error handling path in uniphier_sd_probe() | expand |
On Sat, Feb 20, 2021 at 11:31 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > A 'tmio_mmc_host_free()' call is missing in the remove function, in order > to balance a 'tmio_mmc_host_alloc()' call in the probe. > This is done in the error handling path of the probe, but not in the remove > function. > > Add the missing call. > > Fixes: 3fd784f745dd ("mmc: uniphier-sd: add UniPhier SD/eMMC controller driver") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Masahiro Yamada <masahiroy@kernel.org> > --- > drivers/mmc/host/uniphier-sd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c > index 6f0f05466917..ccbf9885a52b 100644 > --- a/drivers/mmc/host/uniphier-sd.c > +++ b/drivers/mmc/host/uniphier-sd.c > @@ -660,6 +660,7 @@ static int uniphier_sd_remove(struct platform_device *pdev) > > tmio_mmc_host_remove(host); > uniphier_sd_clk_disable(host); > + tmio_mmc_host_free(host); > > return 0; > } > -- > 2.27.0 >
On Sat, 20 Feb 2021 at 15:29, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > A 'tmio_mmc_host_free()' call is missing in the remove function, in order > to balance a 'tmio_mmc_host_alloc()' call in the probe. > This is done in the error handling path of the probe, but not in the remove > function. > > Add the missing call. > > Fixes: 3fd784f745dd ("mmc: uniphier-sd: add UniPhier SD/eMMC controller driver") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied for next and by adding a stable tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/uniphier-sd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c > index 6f0f05466917..ccbf9885a52b 100644 > --- a/drivers/mmc/host/uniphier-sd.c > +++ b/drivers/mmc/host/uniphier-sd.c > @@ -660,6 +660,7 @@ static int uniphier_sd_remove(struct platform_device *pdev) > > tmio_mmc_host_remove(host); > uniphier_sd_clk_disable(host); > + tmio_mmc_host_free(host); > > return 0; > } > -- > 2.27.0 >
diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 6f0f05466917..ccbf9885a52b 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -660,6 +660,7 @@ static int uniphier_sd_remove(struct platform_device *pdev) tmio_mmc_host_remove(host); uniphier_sd_clk_disable(host); + tmio_mmc_host_free(host); return 0; }
A 'tmio_mmc_host_free()' call is missing in the remove function, in order to balance a 'tmio_mmc_host_alloc()' call in the probe. This is done in the error handling path of the probe, but not in the remove function. Add the missing call. Fixes: 3fd784f745dd ("mmc: uniphier-sd: add UniPhier SD/eMMC controller driver") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/mmc/host/uniphier-sd.c | 1 + 1 file changed, 1 insertion(+)