| Message ID | 20210503092157.5689-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-acpi: Disable write protect detection on Toshiba Encore 2 WT8-B | expand |
On 3/05/21 12:21 pm, Hans de Goede wrote: > On the Toshiba Encore 2 WT8-B the microSD slot always reports the card > being write-protected even though microSD cards do not have a write-protect > switch at all. > > Add a new DMI_QUIRK_SD_NO_WRITE_PROTECT quirk entry to sdhci-acpi.c's > DMI quirk table for this. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-acpi.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > index b6574e7fd26b..9e4358d7a0a6 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -820,6 +820,17 @@ static const struct dmi_system_id sdhci_acpi_quirks[] = { > }, > .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, > }, > + { > + /* > + * The Toshiba WT8-B's microSD slot always reports the card being > + * write-protected. > + */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), > + DMI_MATCH(DMI_PRODUCT_NAME, "TOSHIBA ENCORE 2 WT8-B"), > + }, > + .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, > + }, > {} /* Terminating entry */ > }; > >
On Mon, 3 May 2021 at 11:22, Hans de Goede <hdegoede@redhat.com> wrote: > > On the Toshiba Encore 2 WT8-B the microSD slot always reports the card > being write-protected even though microSD cards do not have a write-protect > switch at all. > > Add a new DMI_QUIRK_SD_NO_WRITE_PROTECT quirk entry to sdhci-acpi.c's > DMI quirk table for this. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Applied for next, thanks! Should we tag this for stable? Kind regards Uffe > --- > drivers/mmc/host/sdhci-acpi.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > index b6574e7fd26b..9e4358d7a0a6 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -820,6 +820,17 @@ static const struct dmi_system_id sdhci_acpi_quirks[] = { > }, > .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, > }, > + { > + /* > + * The Toshiba WT8-B's microSD slot always reports the card being > + * write-protected. > + */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), > + DMI_MATCH(DMI_PRODUCT_NAME, "TOSHIBA ENCORE 2 WT8-B"), > + }, > + .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, > + }, > {} /* Terminating entry */ > }; > > -- > 2.31.1 >
Hi, On 5/11/21 12:56 PM, Ulf Hansson wrote: > On Mon, 3 May 2021 at 11:22, Hans de Goede <hdegoede@redhat.com> wrote: >> >> On the Toshiba Encore 2 WT8-B the microSD slot always reports the card >> being write-protected even though microSD cards do not have a write-protect >> switch at all. >> >> Add a new DMI_QUIRK_SD_NO_WRITE_PROTECT quirk entry to sdhci-acpi.c's >> DMI quirk table for this. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Applied for next, thanks! > > Should we tag this for stable? Yes please. Thanks & Regards, Hans >> --- >> drivers/mmc/host/sdhci-acpi.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c >> index b6574e7fd26b..9e4358d7a0a6 100644 >> --- a/drivers/mmc/host/sdhci-acpi.c >> +++ b/drivers/mmc/host/sdhci-acpi.c >> @@ -820,6 +820,17 @@ static const struct dmi_system_id sdhci_acpi_quirks[] = { >> }, >> .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, >> }, >> + { >> + /* >> + * The Toshiba WT8-B's microSD slot always reports the card being >> + * write-protected. >> + */ >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), >> + DMI_MATCH(DMI_PRODUCT_NAME, "TOSHIBA ENCORE 2 WT8-B"), >> + }, >> + .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, >> + }, >> {} /* Terminating entry */ >> }; >> >> -- >> 2.31.1 >> >
On Tue, 11 May 2021 at 12:58, Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 5/11/21 12:56 PM, Ulf Hansson wrote: > > On Mon, 3 May 2021 at 11:22, Hans de Goede <hdegoede@redhat.com> wrote: > >> > >> On the Toshiba Encore 2 WT8-B the microSD slot always reports the card > >> being write-protected even though microSD cards do not have a write-protect > >> switch at all. > >> > >> Add a new DMI_QUIRK_SD_NO_WRITE_PROTECT quirk entry to sdhci-acpi.c's > >> DMI quirk table for this. > >> > >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > > > Applied for next, thanks! > > > > Should we tag this for stable? > > Yes please. Done, thanks! Kind regards Uffe > > Thanks & Regards, > > Hans > > > > > >> --- > >> drivers/mmc/host/sdhci-acpi.c | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > >> index b6574e7fd26b..9e4358d7a0a6 100644 > >> --- a/drivers/mmc/host/sdhci-acpi.c > >> +++ b/drivers/mmc/host/sdhci-acpi.c > >> @@ -820,6 +820,17 @@ static const struct dmi_system_id sdhci_acpi_quirks[] = { > >> }, > >> .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, > >> }, > >> + { > >> + /* > >> + * The Toshiba WT8-B's microSD slot always reports the card being > >> + * write-protected. > >> + */ > >> + .matches = { > >> + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), > >> + DMI_MATCH(DMI_PRODUCT_NAME, "TOSHIBA ENCORE 2 WT8-B"), > >> + }, > >> + .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, > >> + }, > >> {} /* Terminating entry */ > >> }; > >> > >> -- > >> 2.31.1 > >> > > >
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c index b6574e7fd26b..9e4358d7a0a6 100644 --- a/drivers/mmc/host/sdhci-acpi.c +++ b/drivers/mmc/host/sdhci-acpi.c @@ -820,6 +820,17 @@ static const struct dmi_system_id sdhci_acpi_quirks[] = { }, .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, }, + { + /* + * The Toshiba WT8-B's microSD slot always reports the card being + * write-protected. + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), + DMI_MATCH(DMI_PRODUCT_NAME, "TOSHIBA ENCORE 2 WT8-B"), + }, + .driver_data = (void *)DMI_QUIRK_SD_NO_WRITE_PROTECT, + }, {} /* Terminating entry */ };
On the Toshiba Encore 2 WT8-B the microSD slot always reports the card being write-protected even though microSD cards do not have a write-protect switch at all. Add a new DMI_QUIRK_SD_NO_WRITE_PROTECT quirk entry to sdhci-acpi.c's DMI quirk table for this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/mmc/host/sdhci-acpi.c | 11 +++++++++++ 1 file changed, 11 insertions(+)