| Message ID | 20211122103905.14439-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rename RZ/G2L SDHI clocks | expand |
On Mon, Nov 22, 2021 at 10:39:04AM +0000, Biju Das wrote: > Rename the below RZ/G2L clocks to match with the clock names used in > R-Car Gen2 and later generations. > > imclk->core > clk_hs->clkh > imclk2->cd > > This changes will avoid using fallback for RZ/G2L high speed clock, > if "clkh" is not used in device tree and also the code changes in > driver related to this clocks. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> The bindings match what we discussed. Thanks! Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Mon, Nov 22, 2021 at 11:39 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Rename the below RZ/G2L clocks to match with the clock names used in > R-Car Gen2 and later generations. > > imclk->core > clk_hs->clkh > imclk2->cd > > This changes will avoid using fallback for RZ/G2L high speed clock, > if "clkh" is not used in device tree and also the code changes in > driver related to this clocks. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v5.17 if Ulf is happy. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, 23 Nov 2021 at 14:38, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Mon, Nov 22, 2021 at 11:39 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Rename the below RZ/G2L clocks to match with the clock names used in > > R-Car Gen2 and later generations. > > > > imclk->core > > clk_hs->clkh > > imclk2->cd > > > > This changes will avoid using fallback for RZ/G2L high speed clock, > > if "clkh" is not used in device tree and also the code changes in > > driver related to this clocks. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v5.17 if Ulf is happy. Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml index f5107a641790..9ce6e06c19db 100644 --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml @@ -113,17 +113,17 @@ allOf: clocks: items: - description: IMCLK, SDHI channel main clock1. + - description: CLK_HS, SDHI channel High speed clock which operates + 4 times that of SDHI channel main clock1. - description: IMCLK2, SDHI channel main clock2. When this clock is turned off, external SD card detection cannot be detected. - - description: CLK_HS, SDHI channel High speed clock which operates - 4 times that of SDHI channel main clock1. - description: ACLK, SDHI channel bus clock. clock-names: items: - - const: imclk - - const: imclk2 - - const: clk_hs + - const: core + - const: clkh + - const: cd - const: aclk required: - clock-names
Rename the below RZ/G2L clocks to match with the clock names used in R-Car Gen2 and later generations. imclk->core clk_hs->clkh imclk2->cd This changes will avoid using fallback for RZ/G2L high speed clock, if "clkh" is not used in device tree and also the code changes in driver related to this clocks. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- Note: This patch series based on renesas-devel and depend upon [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git/commit/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml?id=e051025efac3929ca7e3e2f2c8860d3447366ebc --- .../devicetree/bindings/mmc/renesas,sdhi.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)