diff mbox series

dt-bindings: mmc: arm,pl18x: Make each example a separate entry

Message ID 20220106182518.1435497-6-robh@kernel.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings: mmc: arm,pl18x: Make each example a separate entry | expand

Commit Message

Rob Herring Jan. 6, 2022, 6:25 p.m. UTC
Each independent example should be a separate entry. This and dropping
'interrupt-parent' allows for 'interrupts' to have different cell sizes.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Linus Walleij Jan. 10, 2022, 4:13 p.m. UTC | #1
On Thu, Jan 6, 2022 at 7:25 PM Rob Herring <robh@kernel.org> wrote:

> Each independent example should be a separate entry. This and dropping
> 'interrupt-parent' allows for 'interrupts' to have different cell sizes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

This is neat!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Rob Herring Jan. 19, 2022, 4:11 p.m. UTC | #2
On Thu, 06 Jan 2022 12:25:14 -0600, Rob Herring wrote:
> Each independent example should be a separate entry. This and dropping
> 'interrupt-parent' allows for 'interrupts' to have different cell sizes.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
index 47595cb483be..2a64cffbe6ad 100644
--- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
+++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
@@ -167,6 +167,9 @@  examples:
       clock-names = "mclk", "apb_pclk";
     };
 
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
     mmc@80126000 {
       compatible = "arm,pl18x", "arm,primecell";
       reg = <0x80126000 0x1000>;
@@ -188,12 +191,12 @@  examples:
       vqmmc-supply = <&vmmci>;
     };
 
+  - |
     mmc@101f6000 {
       compatible = "arm,pl18x", "arm,primecell";
       reg = <0x101f6000 0x1000>;
       clocks = <&sdiclk>, <&pclksdi>;
       clock-names = "mclk", "apb_pclk";
-      interrupt-parent = <&vica>;
       interrupts = <22>;
       max-frequency = <400000>;
       bus-width = <4>;
@@ -208,6 +211,7 @@  examples:
       vmmc-supply = <&vmmc_regulator>;
     };
 
+  - |
     mmc@52007000 {
       compatible = "arm,pl18x", "arm,primecell";
       arm,primecell-periphid = <0x10153180>;