| Message ID | 20220318141441.32329-1-pali@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "mmc: sdhci-xenon: fix annoying 1.8V regulator warning" | expand |
On Fri, 18 Mar 2022 15:14:41 +0100 Pali Rohár <pali@kernel.org> wrote: > This reverts commit bb32e1987bc55ce1db400faf47d85891da3c9b9f. > > Commit 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization") > contains proper fix for the issue described in commit bb32e1987bc5 ("mmc: > sdhci-xenon: fix annoying 1.8V regulator warning"). > > Fixes: 8d876bf472db ("mmc: sdhci-xenon: wait 5ms after set 1.8V signal enable") > Cc: stable@vger.kernel.org # 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization") > Signed-off-by: Pali Rohár <pali@kernel.org> Reviewed-by: Marek Behún <kabel@kernel.org>
Hi, pt., 18 mar 2022 o 16:17 Marek Behún <kabel@kernel.org> napisał(a): > > On Fri, 18 Mar 2022 15:14:41 +0100 > Pali Rohár <pali@kernel.org> wrote: > > > This reverts commit bb32e1987bc55ce1db400faf47d85891da3c9b9f. > > > > Commit 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization") > > contains proper fix for the issue described in commit bb32e1987bc5 ("mmc: > > sdhci-xenon: fix annoying 1.8V regulator warning"). > > > > Fixes: 8d876bf472db ("mmc: sdhci-xenon: wait 5ms after set 1.8V signal enable") > > Cc: stable@vger.kernel.org # 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization") > > Signed-off-by: Pali Rohár <pali@kernel.org> > > Reviewed-by: Marek Behún <kabel@kernel.org> I tested the patch in my setup, so you can add my: Reviewed-by: Marcin Wojtas <mw@semihalf.com> Thanks, Marcin
On Fri, 18 Mar 2022 at 15:14, Pali Rohár <pali@kernel.org> wrote: > > This reverts commit bb32e1987bc55ce1db400faf47d85891da3c9b9f. > > Commit 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization") > contains proper fix for the issue described in commit bb32e1987bc5 ("mmc: > sdhci-xenon: fix annoying 1.8V regulator warning"). > > Fixes: 8d876bf472db ("mmc: sdhci-xenon: wait 5ms after set 1.8V signal enable") > Cc: stable@vger.kernel.org # 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization") > Signed-off-by: Pali Rohár <pali@kernel.org> Applied for fixes, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-xenon.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c > index 666cee4c7f7c..08e838400b52 100644 > --- a/drivers/mmc/host/sdhci-xenon.c > +++ b/drivers/mmc/host/sdhci-xenon.c > @@ -241,16 +241,6 @@ static void xenon_voltage_switch(struct sdhci_host *host) > { > /* Wait for 5ms after set 1.8V signal enable bit */ > usleep_range(5000, 5500); > - > - /* > - * For some reason the controller's Host Control2 register reports > - * the bit representing 1.8V signaling as 0 when read after it was > - * written as 1. Subsequent read reports 1. > - * > - * Since this may cause some issues, do an empty read of the Host > - * Control2 register here to circumvent this. > - */ > - sdhci_readw(host, SDHCI_HOST_CONTROL2); > } > > static unsigned int xenon_get_max_clock(struct sdhci_host *host) > -- > 2.20.1 >
diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c index 666cee4c7f7c..08e838400b52 100644 --- a/drivers/mmc/host/sdhci-xenon.c +++ b/drivers/mmc/host/sdhci-xenon.c @@ -241,16 +241,6 @@ static void xenon_voltage_switch(struct sdhci_host *host) { /* Wait for 5ms after set 1.8V signal enable bit */ usleep_range(5000, 5500); - - /* - * For some reason the controller's Host Control2 register reports - * the bit representing 1.8V signaling as 0 when read after it was - * written as 1. Subsequent read reports 1. - * - * Since this may cause some issues, do an empty read of the Host - * Control2 register here to circumvent this. - */ - sdhci_readw(host, SDHCI_HOST_CONTROL2); } static unsigned int xenon_get_max_clock(struct sdhci_host *host)
This reverts commit bb32e1987bc55ce1db400faf47d85891da3c9b9f. Commit 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization") contains proper fix for the issue described in commit bb32e1987bc5 ("mmc: sdhci-xenon: fix annoying 1.8V regulator warning"). Fixes: 8d876bf472db ("mmc: sdhci-xenon: wait 5ms after set 1.8V signal enable") Cc: stable@vger.kernel.org # 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization") Signed-off-by: Pali Rohár <pali@kernel.org> --- drivers/mmc/host/sdhci-xenon.c | 10 ---------- 1 file changed, 10 deletions(-)