| Message ID | 20220610211257.102071-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] mmc: dw_mmc: exynos: Obviously always return success in remove callback | expand |
On Fri, 10 Jun 2022 at 14:13, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > dw_mci_pltfm_remove() returns 0 unconditionally and returning an error > in a platform remove callback isn't very sensible. (The only effect of > the latter is that the device core emits a generic warning and then > removes the device anyhow.) > > So return 0 unconditionally to make it obvious there is no error > forwarded to the upper layers. > > This is a preparation for making platform remove callbacks return void. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> This one and the other 4 patches in the series, applied for next. Thanks! Kind regards Uffe > --- > drivers/mmc/host/dw_mmc-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index ca5be4445ae0..9f20ac524c8b 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -670,7 +670,9 @@ static int dw_mci_exynos_remove(struct platform_device *pdev) > pm_runtime_set_suspended(&pdev->dev); > pm_runtime_put_noidle(&pdev->dev); > > - return dw_mci_pltfm_remove(pdev); > + dw_mci_pltfm_remove(pdev); > + > + return 0; > } > > static const struct dev_pm_ops dw_mci_exynos_pmops = { > > base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 > -- > 2.36.1 >
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index ca5be4445ae0..9f20ac524c8b 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -670,7 +670,9 @@ static int dw_mci_exynos_remove(struct platform_device *pdev) pm_runtime_set_suspended(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); - return dw_mci_pltfm_remove(pdev); + dw_mci_pltfm_remove(pdev); + + return 0; } static const struct dev_pm_ops dw_mci_exynos_pmops = {
dw_mci_pltfm_remove() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mmc/host/dw_mmc-exynos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56