| Message ID | 20250407092144.35268-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: renesas_sdhi: Use of_get_available_child_by_name() | expand |
On Mon, Apr 07, 2025 at 10:21:41AM +0100, Biju Das wrote: > Use the helper of_get_available_child_by_name() to simplify > renesas_sdhi_probe(). > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Yay! Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Mon, Apr 07, 2025 at 11:37:43AM +0200, Wolfram Sang wrote: > On Mon, Apr 07, 2025 at 10:21:41AM +0100, Biju Das wrote: > > Use the helper of_get_available_child_by_name() to simplify > > renesas_sdhi_probe(). > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Yay! > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> And FWIW, tested with RZ/G3S which does not have the internal regulators. Still boots and works fine: Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
On Mon, 7 Apr 2025 at 11:21, Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Use the helper of_get_available_child_by_name() to simplify > renesas_sdhi_probe(). > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/renesas_sdhi_core.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index fa6526be3638..e26e7995754e 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -1166,12 +1166,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, > if (ret) > goto efree; > > - rcfg.of_node = of_get_child_by_name(dev->of_node, "vqmmc-regulator"); > - if (!of_device_is_available(rcfg.of_node)) { > - of_node_put(rcfg.of_node); > - rcfg.of_node = NULL; > - } > - > + rcfg.of_node = of_get_available_child_by_name(dev->of_node, "vqmmc-regulator"); > if (rcfg.of_node) { > rcfg.driver_data = priv->host; > rdev = devm_regulator_register(dev, &renesas_sdhi_vqmmc_regulator, &rcfg); > -- > 2.43.0 >
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index fa6526be3638..e26e7995754e 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -1166,12 +1166,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, if (ret) goto efree; - rcfg.of_node = of_get_child_by_name(dev->of_node, "vqmmc-regulator"); - if (!of_device_is_available(rcfg.of_node)) { - of_node_put(rcfg.of_node); - rcfg.of_node = NULL; - } - + rcfg.of_node = of_get_available_child_by_name(dev->of_node, "vqmmc-regulator"); if (rcfg.of_node) { rcfg.driver_data = priv->host; rdev = devm_regulator_register(dev, &renesas_sdhi_vqmmc_regulator, &rcfg);
Use the helper of_get_available_child_by_name() to simplify renesas_sdhi_probe(). Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/mmc/host/renesas_sdhi_core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)