From patchwork Sun Aug 6 10:26:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 9883665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D9382603B4 for ; Sun, 6 Aug 2017 10:26:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C971A285EC for ; Sun, 6 Aug 2017 10:26:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD3F4285FB; Sun, 6 Aug 2017 10:26:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B4A3285EC for ; Sun, 6 Aug 2017 10:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbdHFK05 (ORCPT ); Sun, 6 Aug 2017 06:26:57 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:33961 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbdHFK05 (ORCPT ); Sun, 6 Aug 2017 06:26:57 -0400 Received: by mail-wr0-f181.google.com with SMTP id 12so30096852wrb.1 for ; Sun, 06 Aug 2017 03:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=87sfW7/U74++JV5wEVBNKdYRARYLy5g0e9YTDYfT4ps=; b=PBXgxr3GFSEEZHfKsKkHn7/qNKSyXYIZbLllUAJ2sx5FIlgL6QMSY+PJpiDi/SIqso 8s/kFRo1BFkJtrOYlgwwmKNFw8GJIonKwVeKCQMF0Te2LaXuSgZQpR5bztH4I9sIeXKf YoD7vOcNYw/dqnEia60auQ3dQYwRNf2L8Bw8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=87sfW7/U74++JV5wEVBNKdYRARYLy5g0e9YTDYfT4ps=; b=FabEFPW4ddE5efXoIKT82eU0/EzfFlJUt29T588P2NVH10XwBJQFHRNg4bYKwseztp vx7/knP3qY+qdJq00syL8H0Y8K+g6pxE4y2wAEtAWEoCigcoOMDUbPSfoEYTAo/w7/CC 0xSr0vgMd65ytY7hJJkc3VMFkEnqR4hF91qJ4UuDnMFdSiXyvtnxOzCZ3hZYrYX+hswJ s05HSUCMoy6w2e68urKiz2iFLWAxqx5If6781zO6n4nUue2jqZ4U4YO+xU1osHpu4DAq 4D0PytVnyPr3nHmgkGeYFWyzPnR+LjUNhEGqPbyy9jHqiAwRlG82m+nRHI7+TwGRLwF4 kEKg== X-Gm-Message-State: AIVw113Xr4Zze9HVmC99pq609JelcRlU9cDunSaeD9Qtc86InmMpjgzl VgWqTQROBKiVSmj+ X-Received: by 10.223.163.158 with SMTP id l30mr6614095wrb.203.1502015215966; Sun, 06 Aug 2017 03:26:55 -0700 (PDT) Received: from [192.168.0.13] (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.googlemail.com with ESMTPSA id v8sm9370771wrv.16.2017.08.06.03.26.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Aug 2017 03:26:55 -0700 (PDT) Subject: Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef To: Arnd Bergmann , Masahiro Yamada Cc: linux-mmc@vger.kernel.org, Linux Kernel Mailing List , Ulf Hansson , Linus Walleij , Stephen Boyd , Russell King - ARM Linux References: <1501853664-10752-1-git-send-email-yamada.masahiro@socionext.com> From: Srinivas Kandagatla Message-ID: <3b5755df-b94b-741e-81d1-9a13c6f18fd1@linaro.org> Date: Sun, 6 Aug 2017 11:26:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 04/08/17 23:10, Arnd Bergmann wrote: > How about linking the DML code into the mmci module and making that > Kconfig option a 'bool'? Yes, I think making this bool and exporting the two symbols should fix this. It does not make sense to make dml helpers a module anyway. If it sounds okay, I can send a proper patch to fix this. ------------------------>cut<----------------------------------- { @@ -175,3 +176,4 @@ int dml_hw_init(struct mmci_host *host, struct device_node *np) return 0; ------------------------>cut<----------------------------------- thanks, srini --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 5755b69..3345384 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -15,7 +15,7 @@ config MMC_ARMMMCI If unsure, say N. config MMC_QCOM_DML - tristate "Qualcomm Data Mover for SD Card Controller" + bool "Qualcomm Data Mover for SD Card Controller" depends on MMC_ARMMMCI && QCOM_BAM_DMA default y help diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c index 00750c9..e7d9c74 100644 --- a/drivers/mmc/host/mmci_qcom_dml.c +++ b/drivers/mmc/host/mmci_qcom_dml.c @@ -97,6 +97,7 @@ void dml_start_xfer(struct mmci_host *host, struct mmc_data *data) /* make sure the dml is configured before dma is triggered */ wmb(); } +EXPORT_SYMBOL_GPL(dml_start_xfer); static int of_get_dml_pipe_index(struct device_node *np, const char *name)