From patchwork Fri Oct 26 02:57:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 1649791 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 9D22D3FD4E for ; Fri, 26 Oct 2012 02:58:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508Ab2JZC57 (ORCPT ); Thu, 25 Oct 2012 22:57:59 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:58553 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755319Ab2JZC57 (ORCPT ); Thu, 25 Oct 2012 22:57:59 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MCH003D5C7WX3L0@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Fri, 26 Oct 2012 11:57:57 +0900 (KST) X-AuditID: cbfee61b-b7f616d00000319b-a6-5089fc35f674 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 5C.4A.12699.53CF9805; Fri, 26 Oct 2012 11:57:57 +0900 (KST) Received: from [10.90.51.55] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MCH00HYOC8K8670@mmp1.samsung.com> for linux-mmc@vger.kernel.org; Fri, 26 Oct 2012 11:57:57 +0900 (KST) Message-id: <5089FC09.6090101@samsung.com> Date: Fri, 26 Oct 2012 11:57:13 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-version: 1.0 To: linux-mmc Cc: Chris Ball , Will Newton , James Hogan , Kyungmin Park Subject: [PATCH] mmc: dw-mmc: relocate the position called dw_mci_setup_bus() Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMLMWRmVeSWpSXmKPExsVy+t9jAV3TP50BBktbRS2O/O9ndGD0+LxJ LoAxissmJTUnsyy1SN8ugSvj+e5e9oKfnBVXJv9ibWBcx9HFyMkhIWAicWX6CjYIW0ziwr31 QDYXh5DAIkaJz/9usEI47UwSR1v+MIJU8QpoSRxrucYEYrMIqErc33uZBcRmE9CR2P7tOFhc VCBEYsncr+wQ9YISPybfA6sREdCU6Ny+EmwDs8AMRolf946BDRUW8JV4f+EqmM0MNGh/6zQ2 CFteYvOat8wTGPlmIZk1C0nZLCRlCxiZVzGKphYkFxQnpeca6RUn5haX5qXrJefnbmIEB9Uz 6R2MqxosDjEKcDAq8fBuSOsMEGJNLCuuzD3EKMHBrCTCu3sqUIg3JbGyKrUoP76oNCe1+BCj NAeLkjhvs0dKgJBAemJJanZqakFqEUyWiYNTqoFxQcPyw5OjlS9XKivsYXOZJ3ciOPeT5Fr1 uMvG7zw3zA2rz5/kX7vxb53hYU8mjtR7VXuLAzlTl2ycHnf/0BXj81zHL390W2J9fp7i3Vit Fs2vXA27RI6V/LPc7qbFvdvsp59MnOIhfzPFzy/vK7hvY/749H/fBptWC3FHgfbXilvei8Zd YN6ixFKckWioxVxUnAgAQJ4g1yYCAAA= Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org I think right that dw_mci_setup_bus() is called into set_ios(). Actually clock is enabled at dw_mci_setup_bus() in now. Then didn't ensure to wait the 74clock. To stable clock is relocated the position into dw_mci_set_ios(). Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park Acked-by: Seungwon Jeon --- drivers/mmc/host/dw_mmc.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 250aa18..9001844 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -682,9 +682,6 @@ static void __dw_mci_start_request(struct dw_mci *host, if (host->pdata->select_slot) host->pdata->select_slot(slot->id); - /* Slot specific timing and width adjustment */ - dw_mci_setup_bus(slot); - host->cur_slot = slot; host->mrq = mrq; @@ -810,6 +807,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) if (slot->host->drv_data->set_ios) slot->host->drv_data->set_ios(slot->host, ios); + /* Slot specific timing and width adjustment */ + dw_mci_setup_bus(slot); + switch (ios->power_mode) { case MMC_POWER_UP: set_bit(DW_MMC_CARD_NEED_INIT, &slot->flags);