From patchwork Fri Dec 6 23:27:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dinh Nguyen X-Patchwork-Id: 3303361 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EFDBBC0D4A for ; Fri, 6 Dec 2013 23:27:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1CAFE203A7 for ; Fri, 6 Dec 2013 23:27:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39B082038C for ; Fri, 6 Dec 2013 23:27:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759476Ab3LFX1S (ORCPT ); Fri, 6 Dec 2013 18:27:18 -0500 Received: from mail-ob0-f176.google.com ([209.85.214.176]:61500 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759232Ab3LFX1P (ORCPT ); Fri, 6 Dec 2013 18:27:15 -0500 Received: by mail-ob0-f176.google.com with SMTP id va2so1485177obc.7 for ; Fri, 06 Dec 2013 15:27:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=se9+HLCtZ73xfSHt6PGITGDBHqbUo9JxlyBKFlQNBJQ=; b=qJwDMiOvYGrQSvS/9nApslzxGkSvWUSBVgpivqu+8DEtsF2nr5K/fuGm7wVz6pwIGe MpYyE33vgMkmVaPISvkt2xg8RsYLfAggeRogQcHWf94y+P1uL7+CpM3Z3QQHddxaCRs2 D9EeawHD5RomYaVxI6+9CE1bXkqn6YaXXh9Y56fh07viEzC+c5NsncMeN2S20QmSyCjF BNm1s9KsWyXt++/sL7q9vD3RUrLBiRX/5SR5pt0ssltvg1FtN+GEMSw3zDhuFmPEFhGe aFUMwVdxbBkz/x5TqTkmXM0YMTdWHzo+272bOxepxAq9p7y7h2xbJNLPBK4vmjvlD3NO WmkA== X-Received: by 10.60.93.67 with SMTP id cs3mr4510470oeb.12.1386372435189; Fri, 06 Dec 2013 15:27:15 -0800 (PST) Received: from Dinhs-MacBook-Pro.local (99-103-66-154.lightspeed.austtx.sbcglobal.net. [99.103.66.154]) by mx.google.com with ESMTPSA id r3sm383927oep.2.2013.12.06.15.27.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 06 Dec 2013 15:27:14 -0800 (PST) Message-ID: <52A25D45.7000500@gmail.com> Date: Fri, 06 Dec 2013 17:27:01 -0600 From: Dinh Nguyen User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: =?ISO-8859-15?Q?Heiko_St=FCbner?= CC: dinguyen@altera.com, arnd@arndb.de, cjb@laptop.org, jh80.chung@samsung.com, tgih.jun@samsung.com, dianders@chromium.org, alim.akhtar@samsung.com, bzhao@marvell.com, linux-mmc@vger.kernel.org Subject: Re: [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure References: <1386346223-18464-1-git-send-email-dinguyen@altera.com> <201312070014.53895.heiko@sntech.de> <52A25B2F.60209@gmail.com> <201312070022.03414.heiko@sntech.de> In-Reply-To: <201312070022.03414.heiko@sntech.de> X-Enigmail-Version: 1.6 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 12/6/13 5:22 PM, Heiko Stübner wrote: > Am Samstag, 7. Dezember 2013, 00:18:07 schrieb Dinh Nguyen: >> On 12/6/13 5:14 PM, Heiko Stübner wrote: >>> Am Freitag, 6. Dezember 2013, 17:10:23 schrieb dinguyen@altera.com:@@ -42,7 +42,7 @@ >>> /* Common flag combinations */ >>> #define DW_MCI_DATA_ERROR_FLAGS (SDMMC_INT_DRTO | SDMMC_INT_DCRC | \ >>> SDMMC_INT_HTO | SDMMC_INT_SBE | \ >>> - SDMMC_INT_EBE) >>> + SDMMC_INT_EBE | SDMMC_INT_FRUN) >>> #define DW_MCI_CMD_ERROR_FLAGS (SDMMC_INT_RTO | SDMMC_INT_RCRC | \ >>>> From: Dinh Nguyen >>>> >>>> Rockchip's implementation of the dw_mmc controller only requires the >>>> setting of the SDMMC_CMD_USE_HOLD_REG on every command. With the patch >>>> to set the SDMMC_CMD_USE_HOLD_REG by checking the slot's speed mode, >>>> this Rockchip custom driver structure is no longer necessary. >>>> >>>> Signed-off-by: Dinh Nguyen >>> hmm, testing will need a bit more time, as it seems one of the changes >>> merged during the 3.13 merge window broke the dw-mmc on the rockchip. >> Thanks Heiko. Don't bother with v1, I overlooked another aspect of using >> the hold >> reg. Let me send out a v2 for you to test. > Don't worry ... as I've said, first I need to find the current issue :-) What behavior are you seeing? I had to do this apply this for 3.13 when the SD driver is using IDMAC: > > Heiko > --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -42,7 +42,7 @@ /* Common flag combinations */ #define DW_MCI_DATA_ERROR_FLAGS (SDMMC_INT_DRTO | SDMMC_INT_DCRC | \ SDMMC_INT_HTO | SDMMC_INT_SBE | \ - SDMMC_INT_EBE) + SDMMC_INT_EBE | SDMMC_INT_FRUN) #define DW_MCI_CMD_ERROR_FLAGS (SDMMC_INT_RTO | SDMMC_INT_RCRC | \ SDMMC_INT_RESP_ERR) #define DW_MCI_ERROR_FLAGS (DW_MCI_DATA_ERROR_FLAGS | \