From patchwork Wed Jun 4 19:08:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Ball X-Patchwork-Id: 4296581 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 28DC8BEEA7 for ; Wed, 4 Jun 2014 19:09:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6DCA5201B9 for ; Wed, 4 Jun 2014 19:09:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F33720260 for ; Wed, 4 Jun 2014 19:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751921AbaFDTI4 (ORCPT ); Wed, 4 Jun 2014 15:08:56 -0400 Received: from void.printf.net ([89.145.121.20]:48347 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbaFDTIz (ORCPT ); Wed, 4 Jun 2014 15:08:55 -0400 Received: from chris by void.printf.net with local (Exim 4.69) (envelope-from ) id 1WsGYN-0002ha-Nk; Wed, 04 Jun 2014 20:08:51 +0100 From: Chris Ball To: linux-mmc@vger.kernel.org Cc: Ulf Hansson , Jaehoon Chung , Kyungmin Park , Tomasz Figa Subject: [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists Date: Wed, 04 Jun 2014 20:08:51 +0100 Message-ID: <86mwdspk58.fsf@void.printf.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP "mmc: sdhci: push card_tasklet into threaded irq handler" removed the card_tasklet, but it is still in use by sdhci-s3c.c. Signed-off-by: Chris Ball --- Hi, sdhci-s3c is currently failing to build due to the removal of card_tasklet. I think this trivial patch might do the right thing -- please could someone test that card detection still works and ACK if so? Thanks! drivers/mmc/host/sdhci-s3c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 781b8a9..53a32e2 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -399,7 +399,6 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state) clk_disable_unprepare(sc->clk_io); #endif } - tasklet_schedule(&host->card_tasklet); spin_unlock_irqrestore(&host->lock, flags); } }