From patchwork Sun Sep 13 09:56:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Jarzmik X-Patchwork-Id: 7168081 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8D4C3BEEC1 for ; Sun, 13 Sep 2015 10:01:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7425C206B8 for ; Sun, 13 Sep 2015 10:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4009A20644 for ; Sun, 13 Sep 2015 10:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbbIMKBN (ORCPT ); Sun, 13 Sep 2015 06:01:13 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:19503 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbbIMKBM (ORCPT ); Sun, 13 Sep 2015 06:01:12 -0400 Received: from belgarion ([109.220.179.182]) by mwinf5d24 with ME id Ga141r00D3wWvkl03a14T1; Sun, 13 Sep 2015 12:01:10 +0200 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 13 Sep 2015 12:01:10 +0200 X-ME-IP: 109.220.179.182 From: Robert Jarzmik To: Petr Cvek Cc: Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUG] Kernel error when first driver unbind with empty MMC slot References: <55F4EA4F.4050204@tul.cz> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 13 Sep 2015 11:56:12 +0200 In-Reply-To: <55F4EA4F.4050204@tul.cz> (Petr Cvek's message of "Sun, 13 Sep 2015 05:15:27 +0200") Message-ID: <87pp1mskw3.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Petr Cvek writes: > During testing of these patches > > [PATCH] mmc: pxamci: fix card detect threaded interrupt > [PATCH 1/3] dmaengine: virt-dma: don't always free descriptor upon completion > > I have found unrelated error. > > How to reproduce: > > 1) Remove any SD card > 2) No CPLD initial power for card (in magician.c, probably irrelevant) > 3) Boot into an initrd filesystem > 4) Run command echo -n "pxa2xx-mci.0" > /sys/class/mmc_host/mmc0/device/driver/unbind > 5) Error message will be printed: > > [ 97.877519] irq 39: nobody cared (try booting with the "irqpoll" option) To go forward, I need to either : - see the debug messages activated, especially the one pxamci_irq() - or apply this patch [1] to see if it fixes the issue : Cheers. --- Robert [1] Patch, totally untested/not compiled ---8<--- -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 67c9d1443597..3e0a7dd8da84 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -890,9 +890,7 @@ static int pxamci_remove(struct platform_device *pdev) host->pdata->exit(&pdev->dev, mmc); pxamci_stop_clock(host); - writel(TXFIFO_WR_REQ|RXFIFO_RD_REQ|CLK_IS_OFF|STOP_CMD| - END_CMD_RES|PRG_DONE|DATA_TRAN_DONE, - host->base + MMC_I_MASK); + pxamci_disable_irq(host, MMC_I_MASK_ALL); free_irq(host->irq, host); dmaengine_terminate_all(host->dma_chan_rx);