From patchwork Sun Jan 16 21:11:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 482741 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0GLBxAM011151 for ; Sun, 16 Jan 2011 21:12:00 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923Ab1APVL6 (ORCPT ); Sun, 16 Jan 2011 16:11:58 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:55325 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753666Ab1APVL6 convert rfc822-to-8bit (ORCPT ); Sun, 16 Jan 2011 16:11:58 -0500 Received: by pzk35 with SMTP id 35so680348pzk.19 for ; Sun, 16 Jan 2011 13:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=BIvIlXZlkcfD+hW6BdJoEM3CC2I7JCx64OhHSPfqRNk=; b=v19NqKAIhtgx6svnHuWNPOpJk7Y5viOFk7w3GONeevCNmwcaiOzWmqI58KBQA4KhPA X9bp95XM2U73657naugHXsSmritY3qZ3MJQ/WDx7sMOer2agewZ5eYBco5XaBCeY74Q7 sM78O0PDBMfWbB3yn6ekON5sAyNHAEMCFHs0Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=PDXTYir829BUhVaGOXE2bxHTTSh5OdeZD+DZ5+yNE4HrPwEkjXbw+zg9PI4jiKDzSO PVQ1lfnAl0AD2fOMLR5ms/GUeg7bv+H2cyISoDu5tUeI0stcwAlicDbwgm5ZLdEELaM8 ZCsexck/8/qkbNESNX5LCHAqB+yf+jFdbyyNE= MIME-Version: 1.0 Received: by 10.143.1.13 with SMTP id d13mr2854293wfi.184.1295212317557; Sun, 16 Jan 2011 13:11:57 -0800 (PST) Received: by 10.142.174.12 with HTTP; Sun, 16 Jan 2011 13:11:57 -0800 (PST) In-Reply-To: <20110114224439.GR15996@n2100.arm.linux.org.uk> References: <20110101121048.GB25924@n2100.arm.linux.org.uk> <20110105164344.GD8638@n2100.arm.linux.org.uk> <20110114224439.GR15996@n2100.arm.linux.org.uk> Date: Sun, 16 Jan 2011 22:11:57 +0100 Message-ID: Subject: Re: mmci: U300 "sync with blockend" broken for multi-block? From: Linus Walleij To: Russell King - ARM Linux Cc: Rabin Vincent , linux-arm-kernel , Ulf Hansson , Sebastian Rasmussen , linux-mmc@vger.kernel.org Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sun, 16 Jan 2011 21:12:00 +0000 (UTC) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index af0cae9..8ae32d9 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -81,7 +81,7 @@ static struct variant_data variant_u300 = { .fifohalfsize = 8 * 4, .clkreg_enable = 1 << 13, /* HWFCEN */ .datalength_bits = 16, - .broken_blockend = true, + .broken_blockend = false, .sdio = true, }; @@ -414,7 +414,8 @@ static void mmci_start_data(struct mmci_host *host, struct mmc_data *data) void __iomem *base; int blksz_bits; - dev_dbg(mmc_dev(host->mmc), "blksz %04x blks %04x flags %08x\n", + dev_info(mmc_dev(host->mmc), "\n"); + dev_info(mmc_dev(host->mmc), "START DATA: blksz %04x blks %04x flags %08x\n", data->blksz, data->blocks, data->flags);