From patchwork Sun Aug 6 20:41:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9884013 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 631F660363 for ; Sun, 6 Aug 2017 20:41:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CDBA28508 for ; Sun, 6 Aug 2017 20:41:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5189B28577; Sun, 6 Aug 2017 20:41:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDAB328508 for ; Sun, 6 Aug 2017 20:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751353AbdHFUlp (ORCPT ); Sun, 6 Aug 2017 16:41:45 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33001 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbdHFUlo (ORCPT ); Sun, 6 Aug 2017 16:41:44 -0400 Received: by mail-oi0-f67.google.com with SMTP id e124so6090952oig.0; Sun, 06 Aug 2017 13:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=IHYyGVz9Dxr3YeKwDQ3+sQS0r6hksdFCLZnTz9MpM5U=; b=jcm3/uwBvdVlhP9f1EuSuQVypL9goUyNRX1Bj8lFAC71O92doeVYCv8/5KVJKOwrim rP1nris0tGQirdTy0BOtZbvTu2WM5iA1A9XGHdsl93qOsWbm55hq1A3oDGjeAMBakkUQ xtCsE0fBDcGf0rqfa8pSaj+zUtBzfRXYOG2iFMQzWUyD1Uhi+xdJ72AYXHPeOBu113kH XCXdcQpp/4GAeGqtLXRDNKvaQ7TjtxZ2krISURj1KWGqwK/W2LfXUw+UQrPAmBSk4RK9 KjV0lZjUnmXIhhuRt2pjH1Uc7vkumpbcb4KlTCSBnQImUM1LKRWTmORh5G/V9V+s+lb9 7DVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=IHYyGVz9Dxr3YeKwDQ3+sQS0r6hksdFCLZnTz9MpM5U=; b=gNK/Ggh/rvoYL9UmWj/92NJo7iNzKjH36ncStKUI8bY99auh4wW+sIFd6uxfSznxxx Lhh9aerEsK8C76fI6qbKlqoPBB0JgLBieFzVbnRSl3grumlnLreAg9r7Wfm3z/7fHTn5 KsA+PV7NzEmzdx2FBGNh3M4Ek6Y6Am5+QBRsOfCgXy+Ojx3sh/zPza0HYAgUwxdjqyGP pF7vdMCX8ip2hVcP0Xn6vkHJB7L4LaA++lIih1KxPU6XtJm1r7Vb63DVqERtccQAktZL Ix/qiKyXPrzURGpz07fCFMTsWSr7onezzH6sqfUiESHczUfbRDp9TFLa4rdX8wkt3m83 x6Bw== X-Gm-Message-State: AHYfb5hzZv1k6ENM3vnghiBDkQYSTL4dDiZ/F6J4wE6hH8Zoh087RMyW pWsxhOo1NVayJHRvnX+grDUr5p4wZw== X-Received: by 10.202.188.7 with SMTP id m7mr6468297oif.55.1502052103491; Sun, 06 Aug 2017 13:41:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.29.34 with HTTP; Sun, 6 Aug 2017 13:41:42 -0700 (PDT) In-Reply-To: <3b5755df-b94b-741e-81d1-9a13c6f18fd1@linaro.org> References: <1501853664-10752-1-git-send-email-yamada.masahiro@socionext.com> <3b5755df-b94b-741e-81d1-9a13c6f18fd1@linaro.org> From: Arnd Bergmann Date: Sun, 6 Aug 2017 22:41:42 +0200 X-Google-Sender-Auth: YL-9WN1uzl9zkcsv_rx3vPbYum0 Message-ID: Subject: Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef To: Srinivas Kandagatla Cc: Masahiro Yamada , linux-mmc , Linux Kernel Mailing List , Ulf Hansson , Linus Walleij , Stephen Boyd , Russell King - ARM Linux Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Aug 6, 2017 at 12:26 PM, Srinivas Kandagatla wrote: > > > On 04/08/17 23:10, Arnd Bergmann wrote: >> >> How about linking the DML code into the mmci module and making that >> Kconfig option a 'bool'? > > > > Yes, I think making this bool and exporting the two symbols should fix this. > It does not make sense to make dml helpers a module anyway. > > If it sounds okay, I can send a proper patch to fix this. I would say making dml a 'bool' option is not ok unless you also change the Makefile to link it into the same module as the base mmci driver. The alternative is to export the symbols and then always build the dml code as a module when the mmci driver is a module, as below. Or even just move all the code into the base driver, and call it only using an if(IS_ENABLED()) check for the bool symbol. Arnd --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile index 8c46766c000c..5c996cba9f25 100644 --- a/drivers/mmc/host/Makefile +++ b/drivers/mmc/host/Makefile @@ -3,7 +3,9 @@ # obj-$(CONFIG_MMC_ARMMMCI) += mmci.o -obj-$(CONFIG_MMC_QCOM_DML) += mmci_qcom_dml.o +ifdef CONFIG_MMC_QCOM_DML +obj-$(CONFIG_MMC_ARMMMCI) += mmci_qcom_dml.o +endif obj-$(CONFIG_MMC_PXA) += pxamci.o obj-$(CONFIG_MMC_MXC) += mxcmmc.o obj-$(CONFIG_MMC_MXS) += mxs-mmc.o