diff mbox

[mmc:mmc-next,79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status'

Message ID CALtMJEDhBFomn8VEu1G=F8fbZBLO=msTnUCzHSpYsQxEc4WtKw@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Fenkart May 23, 2014, 8:19 a.m. UTC 
2014-05-22 16:24 GMT+02:00 Tony Lindgren <tony@atomide.com>:
> * Chris Ball <chris@printf.net> [140522 05:42]:
>> Hi,
>>
>> On Thu, May 22 2014, Ulf Hansson wrote:
>> > I had a second look at Andreas Fenkart's patchset to enable SDIO irq
>> > for omap. Those needs an additional iteration, since there are
>> > unresolved dependencies to CONFIG_PM_RUNTIME (and possibly to other
>> > Kconfigs as well). Apparently I had all the needed Kconfigs enabled
>> > while I compile tested them. :-(
>
> Did you find this out with make randconfig?

FYI

after this patch I could deselect CONFIG_PM


>
>> > I tried out doing a local re-base, to remove the related omap patches.
>> > If you remove the patches below you won't get any conflicts for
>> > omap_hsmmc. Can you do that?
>> >
>> > Andreas:
>> > mmc: omap_hsmmc: Enable SDIO interrupt
>> > mmc: omap_hsmmc: enable wakeup event for sdio OMAP4
>> > mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state
>> > mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected
>> > mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks
>> > mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x
>> >
>> > Balaji:
>> > mmc: omap_hsmmc: use IS_ERR macro for error checking
>>
>> Done.  Thanks!
>
> Andreas, can you fix this ASAP? Would be nice to have those
> working for v3.16 :)
will send out updated patches soon
>
> Once you have updated patches available I'll include them
> also to my randconfig builds. Unless the Kconfig options
> are nested they are exposed after few builds typically.
>
> Regards,
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Balaji T K May 23, 2014, 8:27 a.m. UTC | #1 
On Friday 23 May 2014 01:49 PM, Andreas Fenkart wrote:
> 2014-05-22 16:24 GMT+02:00 Tony Lindgren <tony@atomide.com>:
>> * Chris Ball <chris@printf.net> [140522 05:42]:
>>> Hi,
>>>
>>> On Thu, May 22 2014, Ulf Hansson wrote:
>>>> I had a second look at Andreas Fenkart's patchset to enable SDIO irq
>>>> for omap. Those needs an additional iteration, since there are
>>>> unresolved dependencies to CONFIG_PM_RUNTIME (and possibly to other
>>>> Kconfigs as well). Apparently I had all the needed Kconfigs enabled
>>>> while I compile tested them. :-(
>>
>> Did you find this out with make randconfig?
>
> FYI
>
> after this patch I could deselect CONFIG_PM
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -111,7 +111,6 @@ config ARCH_OMAP2PLUS_TYPICAL
>          select I2C_OMAP
>          select MENELAUS if ARCH_OMAP2
>          select NEON if CPU_V7
> -       select PM_RUNTIME
>          select REGULATOR
>          select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
>          select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
>
>
>>
>>>> I tried out doing a local re-base, to remove the related omap patches.
>>>> If you remove the patches below you won't get any conflicts for
>>>> omap_hsmmc. Can you do that?
>>>>
>>>> Andreas:
>>>> mmc: omap_hsmmc: Enable SDIO interrupt
>>>> mmc: omap_hsmmc: enable wakeup event for sdio OMAP4
>>>> mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state
>>>> mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected
>>>> mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks
>>>> mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x
>>>>
>>>> Balaji:
>>>> mmc: omap_hsmmc: use IS_ERR macro for error checking
>>>
>>> Done.  Thanks!
>>
>> Andreas, can you fix this ASAP? Would be nice to have those
>> working for v3.16 :)
> will send out updated patches soon

Thanks Andreas,
If it helps, how about sending the fix as separate patch,
That way it will be easier for reviewing!

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -111,7 +111,6 @@  config ARCH_OMAP2PLUS_TYPICAL
        select I2C_OMAP
        select MENELAUS if ARCH_OMAP2
        select NEON if CPU_V7
-       select PM_RUNTIME
        select REGULATOR
        select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
        select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4