From patchwork Mon Jun 20 19:10:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 898152 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5KJAoU0012696 for ; Mon, 20 Jun 2011 19:12:25 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755398Ab1FTTK5 (ORCPT ); Mon, 20 Jun 2011 15:10:57 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:59166 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755388Ab1FTTK5 (ORCPT ); Mon, 20 Jun 2011 15:10:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Date:Sender:Message-Id:Content-Type:MIME-Version:Cc:Subject:Cc:To:From:References:In-Reply-To; bh=GdC7hyBKl7t8yzePYbM35gANSILfexQMzNrQGqvYsyk=; b=psaNzRfaz/TW2X2FE9M17smWpMJSlLQnkHoMljJrI4yOC0Wjql1mBELr272oveOC6fA6+WzWQTeFwQGi++mgMxEEgBj/XcbKNLxRDC42GFOrles3vGJDe5nndyThbx0pQf/YfG+AVbygetENQ7WAkFcgofsNJNtovhnDYareQxY=; Received: from e0022681537dd.dyn.arm.linux.org.uk ([2002:4e20:1eda:1:222:68ff:fe15:37dd] helo=rmk-PC.arm.linux.org.uk) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1QYjs2-0001Xt-IK; Mon, 20 Jun 2011 20:10:50 +0100 Received: from rmk by rmk-PC.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1QYjs1-000806-20; Mon, 20 Jun 2011 20:10:49 +0100 In-Reply-To: <20110620190945.GK26089@n2100.arm.linux.org.uk> References: <20110620190945.GK26089@n2100.arm.linux.org.uk> From: Russell King - ARM Linux To: Chris Ball Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] MMC: add checking of r/w command response Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Mon, 20 Jun 2011 20:10:49 +0100 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 20 Jun 2011 19:12:25 +0000 (UTC) Check the status bits in the r/w command response for any errors. If error bits are set, then we won't have seen any data transferred, so its pointless doing any further checking. Signed-off-by: Russell King --- drivers/mmc/card/block.c | 26 +++++++++++++++++++++++++- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index aa074c8..e5d1c8a 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -812,6 +812,14 @@ static inline void mmc_apply_rel_rw(struct mmc_blk_request *brq, } } +#define CMD_ERRORS \ + (R1_OUT_OF_RANGE | /* Command argument out of range */ \ + R1_ADDRESS_ERROR | /* Misaligned address */ \ + R1_BLOCK_LEN_ERROR | /* Transferred block length incorrect */\ + R1_WP_VIOLATION | /* Tried to write to protected block */ \ + R1_CC_ERROR | /* Card controller error */ \ + R1_ERROR) /* General/unknown error */ + static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *req) { struct mmc_blk_data *md = mq->data; @@ -967,6 +975,22 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *req) } } + /* + * Check for errors relating to the execution of the + * initial command - such as address errors. No data + * has been transferred. + */ + if (brq.cmd.resp[0] & CMD_ERRORS) { + pr_err("%s: r/w command failed, status = %#x\n", + req->rq_disk->disk_name, brq.cmd.resp[0]); + goto cmd_abort; + } + + /* + * Everything else is either success, or a data error of some + * kind. If it was a write, we may have transitioned to + * program mode, which we have to wait for it to complete. + */ if (!mmc_host_is_spi(card->host) && rq_data_dir(req) != READ) { u32 status; do { @@ -986,7 +1010,7 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *req) } if (brq.data.error) { - pr_err("%s: error %d transferring data, sector %u nr %u, cmd response %#x card status %#x\n", + pr_err("%s: error %d transferring data, sector %u, nr %u, cmd response %#x, card status %#x\n", req->rq_disk->disk_name, brq.data.error, (unsigned)blk_rq_pos(req), (unsigned)blk_rq_sectors(req),