From patchwork Wed Mar 22 21:18:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9640107 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4217860327 for ; Wed, 22 Mar 2017 21:34:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 32FD52521E for ; Wed, 22 Mar 2017 21:34:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27D8A262F2; Wed, 22 Mar 2017 21:34:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D14302521E for ; Wed, 22 Mar 2017 21:34:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753796AbdCVVek (ORCPT ); Wed, 22 Mar 2017 17:34:40 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35901 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbdCVVeN (ORCPT ); Wed, 22 Mar 2017 17:34:13 -0400 Received: by mail-wm0-f66.google.com with SMTP id x124so13082012wmf.3 for ; Wed, 22 Mar 2017 14:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=p2k8aLoq0hkEvsYO+H7fmXoSJBTmlUneInBJLWctoRQ=; b=JGyxodYFV2gDoq5oc89u3rJrI0yd1M676WiltKGtJRJnSmGmBC5y+5gyG0mBGJUAuu JhoJ+Pskt1uAX0ZyQEeQmCABWtnK3MMsclI/Ld+gKn6/pG55NvX0pvVXApTXqLHTY2bI uzIDdtJyspafAnr952C0h0UTeM9mQ40pHIEn7wAdYp9YiUa9QLRU83JJVw74FVHp8vfQ Mv5d9oTXUYyYU2oRQNFkE2TPgEyr+Up60EzATfIgj8jxB41oFLzcscSMbh6NjQykXYJY DDxU1Y5rNWN/Pr68lPY5kkLcYBXUTdPy3oxo6zGv4y0fK+2FLCw33hvqGn/fQb/ZxnIg ThmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=p2k8aLoq0hkEvsYO+H7fmXoSJBTmlUneInBJLWctoRQ=; b=VocpT8AGYpekgt+P5MUu2WwxFtqQVUXlzAKgcFao7sTmHgkxiFh7V86Hsa8+N4gZAl CQiMpLP+wRt1nTMieD7m85omnN2tnaCMvN5hBWUjzN348q8ETVlh1AnXx9g8mDMEOouT IkGTHuv0vw56VS7Hs+yk6LJ/tOrAbIqtcFbeLruNTGwII788XcK+ZODO/J9T6runpfwv kDIk+z2GFFWXnOpQhIXgRcjqs/51x8VGvkXwlbTLPeR4mIklHSMINsnhYDd4Hi2HSoPH u9OgJOYET1HG/vnXvGRuY9tx0BvOu7u9DDoEu+7JHuIqYaBueKw7ISCH7GMdpFi+oqkF 7jXw== X-Gm-Message-State: AFeK/H1mSDwSle6yFQi1yrybHOFVTWhF5Lnm/iKL6I5mnjEcTDzxz9+hq0VcdaUfnpMvTA== X-Received: by 10.28.107.14 with SMTP id g14mr10268666wmc.106.1490218451824; Wed, 22 Mar 2017 14:34:11 -0700 (PDT) Received: from ?IPv6:2003:c6:ebdc:4000:94d5:56f1:aebf:596a? (p200300C6EBDC400094D556F1AEBF596A.dip0.t-ipconnect.de. [2003:c6:ebdc:4000:94d5:56f1:aebf:596a]) by smtp.googlemail.com with ESMTPSA id g23sm1768701wme.8.2017.03.22.14.34.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 14:34:11 -0700 (PDT) Subject: [PATCH 1/6] mmc: meson-gx: remove unneeded configuration bit resets To: Ulf Hansson , Kevin Hilman References: <8bf58a83-d8d7-615c-c89b-87a62a3c9c40@gmail.com> Cc: "linux-mmc@vger.kernel.org" , linux-amlogic@lists.infradead.org From: Heiner Kallweit Message-ID: Date: Wed, 22 Mar 2017 22:18:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8bf58a83-d8d7-615c-c89b-87a62a3c9c40@gmail.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The variables holding the configuration bits are zero-initialized. So we can remove all bit resets. Signed-off-by: Heiner Kallweit --- drivers/mmc/host/meson-gx-mmc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index bd075fef..04a55577 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -441,7 +441,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd) /* Response */ if (cmd->flags & MMC_RSP_PRESENT) { - desc->cmd_cfg &= ~CMD_CFG_NO_RESP; if (cmd->flags & MMC_RSP_136) desc->cmd_cfg |= CMD_CFG_RESP_128; desc->cmd_cfg |= CMD_CFG_RESP_NUM; @@ -479,7 +478,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd) writel(cfg, host->regs + SD_EMMC_CFG); } } else { - desc->cmd_cfg &= ~CMD_CFG_BLOCK_MODE; desc->cmd_cfg |= (cmd->data->blksz & CMD_CFG_LENGTH_MASK) << CMD_CFG_LENGTH_SHIFT; @@ -494,15 +492,12 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd) host->bounce_buf, xfer_bytes); cmd->data->bytes_xfered = xfer_bytes; dma_wmb(); - } else { - desc->cmd_cfg &= ~CMD_CFG_DATA_WR; } desc->cmd_data = host->bounce_dma_addr & CMD_DATA_MASK; cmd_cfg_timeout = ilog2(SD_EMMC_CMD_TIMEOUT_DATA); } else { - desc->cmd_cfg &= ~CMD_CFG_DATA_IO; cmd_cfg_timeout = ilog2(SD_EMMC_CMD_TIMEOUT); } desc->cmd_cfg |= (cmd_cfg_timeout & CMD_CFG_TIMEOUT_MASK) <<