diff mbox series

[2/2] mmc: renesas_sdhi_internal_dmac: fix comment typo

Message ID c83a18f4-8901-b631-9ba9-ab102e216b3a@cogentembedded.com (mailing list archive)
State New, archived
Headers show
Series Fix some typos in Renesas R-Car gen3 SDHI driver | expand

Commit Message

Sergei Shtylyov Aug. 17, 2018, 8:20 p.m. UTC
Fix the typo in the comment to #define DTRAN_MODE_CH_NUM_CH1.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/mmc/host/renesas_sdhi_internal_dmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang Aug. 20, 2018, 4:48 p.m. UTC | #1
On Fri, Aug 17, 2018 at 11:20:23PM +0300, Sergei Shtylyov wrote:
> Fix the typo in the comment to #define DTRAN_MODE_CH_NUM_CH1.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

...but I really think those two patches should be squashed. One patch
per typo is too fine grained IMO.
Simon Horman Aug. 21, 2018, 1:22 p.m. UTC | #2
On Fri, Aug 17, 2018 at 11:20:23PM +0300, Sergei Shtylyov wrote:
> Fix the typo in the comment to #define DTRAN_MODE_CH_NUM_CH1.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
diff mbox series

Patch

Index: mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
===================================================================
--- mmc.orig/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -35,7 +35,7 @@ 
 
 /* DM_CM_DTRAN_MODE */
 #define DTRAN_MODE_CH_NUM_CH0	0	/* "downstream" = for write commands */
-#define DTRAN_MODE_CH_NUM_CH1	BIT(16)	/* "uptream" = for read commands */
+#define DTRAN_MODE_CH_NUM_CH1	BIT(16)	/* "upstream" = for read commands */
 #define DTRAN_MODE_BUS_WIDTH	(BIT(5) | BIT(4))
 #define DTRAN_MODE_ADDR_MODE	BIT(0)	/* 1 = Increment address */