| Message ID | d7c8bc0143c6b8c8b313413860840ae5bf2dc22a.1716277695.git.andrea.porta@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add minimal boot support for Raspberry Pi 5 | expand |
Hi Andrea, Am 21.05.24 um 10:35 schrieb Andrea della Porta: > The BCM2712 has an SDHCI capable host interface similar to the one found > in other STB chipsets. Add the relevant compatible string. > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > --- > Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > index cbd3d6c6c77f..d584a7ea707a 100644 > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > @@ -13,6 +13,10 @@ maintainers: > properties: > compatible: > oneOf: > + - items: > + - enum: > + - brcm,bcm2712-sdhci > + - const: brcm,sdhci-brcmstb sorry i didn't noticed in V2, but why can't we just extend the second items list? > - items: > - enum: > - brcm,bcm7216-sdhci
On 13:56 Tue 21 May , Stefan Wahren wrote: > Hi Andrea, > > Am 21.05.24 um 10:35 schrieb Andrea della Porta: > > The BCM2712 has an SDHCI capable host interface similar to the one found > > in other STB chipsets. Add the relevant compatible string. > > > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > > --- > > Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > index cbd3d6c6c77f..d584a7ea707a 100644 > > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > @@ -13,6 +13,10 @@ maintainers: > > properties: > > compatible: > > oneOf: > > + - items: > > + - enum: > > + - brcm,bcm2712-sdhci > > + - const: brcm,sdhci-brcmstb > sorry i didn't noticed in V2, but why can't we just extend the second > items list? Hi Stefan, I initially thought that the two different item lists represent two different controller families, but now that you point that out, I'm more and more convinced that probably we can shorten the representation as you are suggesting, adding 'brcm,bcm2712-sdhci' to the second item list enum. Will be so in V4. Many thanks, Andrea > > - items: > > - enum: > > - brcm,bcm7216-sdhci >
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml index cbd3d6c6c77f..d584a7ea707a 100644 --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml @@ -13,6 +13,10 @@ maintainers: properties: compatible: oneOf: + - items: + - enum: + - brcm,bcm2712-sdhci + - const: brcm,sdhci-brcmstb - items: - enum: - brcm,bcm7216-sdhci
The BCM2712 has an SDHCI capable host interface similar to the one found in other STB chipsets. Add the relevant compatible string. Signed-off-by: Andrea della Porta <andrea.porta@suse.com> --- Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 ++++ 1 file changed, 4 insertions(+)