From patchwork Thu Nov 8 15:09:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 1716271 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 4A3C6E0010 for ; Thu, 8 Nov 2012 15:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755941Ab2KHPJ0 (ORCPT ); Thu, 8 Nov 2012 10:09:26 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:54233 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756128Ab2KHPJX (ORCPT ); Thu, 8 Nov 2012 10:09:23 -0500 Received: by mail-pb0-f46.google.com with SMTP id rr4so2100370pbb.19 for ; Thu, 08 Nov 2012 07:09:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :in-reply-to:references:x-gm-message-state; bh=Mg5K554TB4JmQ/pBXM//DrhyFJyeCplIbRRku+wYlJg=; b=KXomRBd06dZ2O4ysc6Xia3XBp7ldj5YP440sa4bdMKbuQ29Fze5KVoPmlezy07hI2v ylhxQ9dnRatNV9FqZKsekZJjAalLVT1P/aHe2vkEnlzP3fGHQyp+kjKve9dgwTfDwqEE 4trSRp9izubTXM8hN0uYgzUgbJLK5wln8tRqi8KXlIG4r5dc76mZr9ePf/n709PDAFvl /50UUFXtk2XW5jkL/auKclnexhby3omhSeN5XpwJdovuYrQsEeVNSfVgQ/6lvkCq0511 81JXHODfxHvNbHa4Z3i5fuLmSwHZN4lpVaLBKF7H31xX7Ko6Tnmkfsz5A7XBLHEEjQPE PRWQ== Received: by 10.68.189.8 with SMTP id ge8mr25298521pbc.24.1352387363440; Thu, 08 Nov 2012 07:09:23 -0800 (PST) Received: from localhost ([122.167.75.112]) by mx.google.com with ESMTPS id n7sm16258552pav.26.2012.11.08.07.09.20 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Nov 2012 07:09:23 -0800 (PST) From: Viresh Kumar To: cjb@laptop.org Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, Viresh Kumar Subject: [PATCH 2/2] mmc: sdhci-spear: Don't call clk_{un}prepare() in suspend resume Date: Thu, 8 Nov 2012 20:39:10 +0530 Message-Id: X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: X-Gm-Message-State: ALoCoQlzhwCZ7+WjlikjvhCB1qZ+OZOtB8kUi9RhkgRSO82K9ZOWAFzbx2NTEs7gFuLX/cpXq3Dz Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org clk_{un}prepare is mandatory for platforms using common clock framework. Because for SPEAr we don't do anything in clk_{un}prepare() calls, just call them ones in probe/remove. Signed-off-by: Viresh Kumar --- drivers/mmc/host/sdhci-spear.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index fea8bf9..87a7009 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -302,7 +302,7 @@ static int sdhci_suspend(struct device *dev) ret = sdhci_suspend_host(host); if (!ret) - clk_disable_unprepare(sdhci->clk); + clk_disable(sdhci->clk); return ret; } @@ -313,7 +313,7 @@ static int sdhci_resume(struct device *dev) struct spear_sdhci *sdhci = dev_get_platdata(dev); int ret; - ret = clk_prepare_enable(sdhci->clk); + ret = clk_enable(sdhci->clk); if (ret) { dev_dbg(dev, "Resume: Error enabling clock\n"); return ret;