| Message ID | ee4ad0e7e131e4d639dbf6bd25ad93726648ce1c.1558346019.git.baolin.wang@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add SD host controller support for SC9860 platform | expand |
On Mon, 20 May 2019 at 12:12, Baolin Wang <baolin.wang@linaro.org> wrote: > > For some Spreadtrum platforms like SC9860 platform, we should enable another > gate clock '2x_enable' to make the SD host controller work well. Thus add > documentation for this optional clock. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > .../devicetree/bindings/mmc/sdhci-sprd.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > index 45c9978..a285c77 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > @@ -14,6 +14,7 @@ Required properties: > - clock-names: Should contain the following: > "sdio" - SDIO source clock (required) > "enable" - gate clock which used for enabling/disabling the device (required) > + "2x_enable" - gate clock controlling the device for some special platforms (optional) This is a bit vague, could you please elaborate (and fold in that information to the doc) on what kind of clock this is? [...] Kind regards Uffe
Hi Ulf, On Mon, 3 Jun 2019 at 21:34, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Mon, 20 May 2019 at 12:12, Baolin Wang <baolin.wang@linaro.org> wrote: > > > > For some Spreadtrum platforms like SC9860 platform, we should enable another > > gate clock '2x_enable' to make the SD host controller work well. Thus add > > documentation for this optional clock. > > > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > --- > > .../devicetree/bindings/mmc/sdhci-sprd.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > index 45c9978..a285c77 100644 > > --- a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > +++ b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > @@ -14,6 +14,7 @@ Required properties: > > - clock-names: Should contain the following: > > "sdio" - SDIO source clock (required) > > "enable" - gate clock which used for enabling/disabling the device (required) > > + "2x_enable" - gate clock controlling the device for some special platforms (optional) > > This is a bit vague, could you please elaborate (and fold in that > information to the doc) on what kind of clock this is? Sorry for confusing. For some Spreadtrum platfroms like SC9860 platform, we should enable 2 gate clocks to enable SD host controller, that means we have 2 serialized clock gates. I know that's a little weird, but that's our clock's design.
On Tue, 4 Jun 2019 at 04:33, Baolin Wang <baolin.wang@linaro.org> wrote: > > Hi Ulf, > > On Mon, 3 Jun 2019 at 21:34, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > On Mon, 20 May 2019 at 12:12, Baolin Wang <baolin.wang@linaro.org> wrote: > > > > > > For some Spreadtrum platforms like SC9860 platform, we should enable another > > > gate clock '2x_enable' to make the SD host controller work well. Thus add > > > documentation for this optional clock. > > > > > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > > > --- > > > .../devicetree/bindings/mmc/sdhci-sprd.txt | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > > index 45c9978..a285c77 100644 > > > --- a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > > +++ b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt > > > @@ -14,6 +14,7 @@ Required properties: > > > - clock-names: Should contain the following: > > > "sdio" - SDIO source clock (required) > > > "enable" - gate clock which used for enabling/disabling the device (required) > > > + "2x_enable" - gate clock controlling the device for some special platforms (optional) > > > > This is a bit vague, could you please elaborate (and fold in that > > information to the doc) on what kind of clock this is? > > Sorry for confusing. For some Spreadtrum platfroms like SC9860 > platform, we should enable 2 gate clocks to enable SD host controller, > that means we have 2 serialized clock gates. I know that's a little > weird, but that's our clock's design. Okay, just wanted to make sure this new clock isn't something that should be modeled through the clock tree. Thanks for explaining, then I am happy with the patch as is. Kind regards Uffe
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt index 45c9978..a285c77 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt +++ b/Documentation/devicetree/bindings/mmc/sdhci-sprd.txt @@ -14,6 +14,7 @@ Required properties: - clock-names: Should contain the following: "sdio" - SDIO source clock (required) "enable" - gate clock which used for enabling/disabling the device (required) + "2x_enable" - gate clock controlling the device for some special platforms (optional) Optional properties: - assigned-clocks: the same with "sdio" clock
For some Spreadtrum platforms like SC9860 platform, we should enable another gate clock '2x_enable' to make the SD host controller work well. Thus add documentation for this optional clock. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- .../devicetree/bindings/mmc/sdhci-sprd.txt | 1 + 1 file changed, 1 insertion(+)