[0/4] kmod: Paper cuts - dead code removal, don't SED manually

Message

Emil Velikov Feb. 21, 2023, 1:19 p.m. UTC

Greetings everyone,

Here's another, final, round of paper cuts while browsing through the project.

Note that despite the enabled linker garbage collector, the first few cleanup
patches result in detectable improvement in the final binaries.

The last patch, removes the open-coded replacement and by doing so fixes a
genuine bug - albeit one that is uncommon to hit.

As always, feel free to pick any bits that seem suitable.

Thanks
Emil

Emil Velikov (4):
  libkmod: remove unused kmod_module_get_builtin
  libkmod: annotate kmod_builtin_iter API as static
  shared: annotate local API as static
  configure: manage libkmod.pc.in and version.py.in via AC_CONFIG_FILES

 Makefile.am                | 25 ----------------------
 configure.ac               |  2 ++
 libkmod/libkmod-builtin.c  |  8 +++----
 libkmod/libkmod-internal.h |  6 ------
 libkmod/libkmod-module.c   | 43 --------------------------------------
 shared/util.c              |  6 +++---
 shared/util.h              |  3 ---
 7 files changed, 9 insertions(+), 84 deletions(-)

Comments

Lucas De Marchi Feb. 22, 2023, 12:40 a.m. UTC | #1

On Tue, 21 Feb 2023 13:19:25 +0000, Emil Velikov wrote:
> Here's another, final, round of paper cuts while browsing through the project.
> 
> Note that despite the enabled linker garbage collector, the first few cleanup
> patches result in detectable improvement in the final binaries.
> 
> The last patch, removes the open-coded replacement and by doing so fixes a
> genuine bug - albeit one that is uncommon to hit.
> 
> [...]

Applied all the patches, thanks!

[1/4] libkmod: remove unused kmod_module_get_builtin
      commit: 0237665beff4fa5e45b1d1ac5857627f949721b5
[2/4] libkmod: annotate kmod_builtin_iter API as static
      commit: df9d07a1492d7185413985add42ab38650ec2378
[3/4] shared: annotate local API as static
      commit: 06e6f167c211106212290aa7980880f972d71ba2
[4/4] configure: manage libkmod.pc.in and version.py.in via AC_CONFIG_FILES
      commit: e4c1a5b2998bc2c9dbcff8d62f121d1f8f5f4fe5

My intention is to release kmod 31 soon. Let me know if you have
anything pending that you'd like in the next release.  If nothing is pending I may just
do a release in the next days/week.


Best regards,

Emil Velikov Feb. 22, 2023, 11:50 a.m. UTC | #2

Greetings Lucas,

On Wed, 22 Feb 2023 at 00:40, Lucas De Marchi <[e-mail]> wrote:

> My intention is to release kmod 31 soon. Let me know if you have
> anything pending that you'd like in the next release.  If nothing is pending I may just
> do a release in the next days/week.
>

There are no other patches on my end - rolling a release would be great.

Thanks o/
Emil