[kmod,0/3] libkmod: misc ABI changes

Message

Emil Velikov via B4 Relay July 19, 2024, 4:12 p.m. UTC

Hello all,

Recently I've noticed that new API was added into the incorrect section
of the version script. Thus the resulting library had incorrectly tagged
symbol(s) in the exports list.

As result I went ahead and checked for other ABI issues and I've noticed
that v26 and v27 have some changes in enum kmod_index. Although on
inspection neither of these should have caused issues in reality:

 - v26 changes the _KMOD_INDEX_PAD from signed to unsigned, all other
   enum values are identical
 - v27 adds new enum, effectively changing the final (non-pad) enum
   value. My search has found zero users of change and new enums, and
   single (abandoned) user of the kmod_dump_index() API (which uses the
   enum in the first place)

The respective commits have additional details and reasoning.

Personally I would recommend picking patch 2 across all distros and
patch 3, if your distro is shipping kmod version from git.

Cc-ing Debian, Fedora and RedHat maintainers - team, please forward this
to any fellow maintainers I may have missed.

Thanks in advance,

To: [e-mail]

---
Emil Velikov (3):
      libkmod: document KMOD_INDEX_MODULES_BUILTIN_ALIAS in kmod_dump_index()
      libkmod: correctly tag kmod_module_new_from_name_lookup
      libkmod: move new weak API to separate section

 libkmod/libkmod.c   |  1 +
 libkmod/libkmod.sym | 14 +++++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)
---
base-commit: fa715f8c8b78a09f47701ce1cf46e9b67a49b8d0
change-id: 20240717-abi-fixes-70771afcbe19

Best regards,