From patchwork Mon May 2 14:38:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SMOpY3RvciBPcsOzbiBNYXJ0w61uZXo=?= X-Patchwork-Id: 8993041 Return-Path: X-Original-To: patchwork-linux-modules@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 534E3BF29F for ; Mon, 2 May 2016 14:42:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7D3EF20211 for ; Mon, 2 May 2016 14:42:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D2F6201F2 for ; Mon, 2 May 2016 14:42:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754006AbcEBOjO (ORCPT ); Mon, 2 May 2016 10:39:14 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57982 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292AbcEBOjI (ORCPT ); Mon, 2 May 2016 10:39:08 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: zumbi) with ESMTPSA id 566862660F9 From: hector.oron@gmail.com To: linux-modules@vger.kernel.org Cc: =?UTF-8?q?H=C3=A9ctor=20Or=C3=B3n=20Mart=C3=ADnez?= Subject: [PATCH] kmod: compiling with old sed version (!ERE support) Date: Mon, 2 May 2016 16:38:24 +0200 Message-Id: <1462199904-797-1-git-send-email-hector.oron@gmail.com> X-Mailer: git-send-email 2.8.0.rc3 MIME-Version: 1.0 Sender: owner-linux-modules@vger.kernel.org Precedence: bulk List-ID: X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Héctor Orón Martínez Makefile.am uses `sed -E', which it is found on BSD sed; however a replacement on GNU sed would be `sed -r'. Both intend to use extended regular expressions (ERE). However I have a system that does not support those, in benefit for portability could you consider replacing ERE by BRE. Signed-off-by: Héctor Orón Martínez --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 2d9f2cf..8813475 100644 --- a/Makefile.am +++ b/Makefile.am @@ -107,7 +107,7 @@ install-exec-hook: if test "$(libdir)" != "$(rootlibdir)"; then \ $(MKDIR_P) $(DESTDIR)$(rootlibdir) && \ so_img_name=$$(readlink $(DESTDIR)$(libdir)/libkmod.so) && \ - so_img_rel_target_prefix=$$(echo $(libdir) | sed -E 's,(^/|)[^/][^/]*,..,g') && \ + so_img_rel_target_prefix=$$(echo $(libdir) | sed 's,\(^/\|\)[^/][^/]*,..,g') && \ ln -sf $$so_img_rel_target_prefix$(rootlibdir)/$$so_img_name $(DESTDIR)$(libdir)/libkmod.so && \ mv $(DESTDIR)$(libdir)/libkmod.so.* $(DESTDIR)$(rootlibdir); \ fi