From patchwork Fri May 10 08:57:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jose Ignacio Tornos Martinez X-Patchwork-Id: 13661064 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70B424C7D for ; Fri, 10 May 2024 08:58:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715331532; cv=none; b=l2WjtBLJr3g4Ikz3n1kPq7UghA32dxSJ3Dyn+AKI7tJxecK7k4pd+2aCCrJ73nfk7p7aNxg10ntUrceraXLxksyWOxuHk+ep5JzyFi302lAV1FA37bnRr9WiNNXOsJB7m0hIh2LZlzd94J8qAj5ylOtzVWsp+IQZQ1+aMIqYdD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715331532; c=relaxed/simple; bh=i7lzNbNU766SPvXgvLbc9nKxUz6ZhlRWGGhNlC8Djwo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UXhep1Ydn0AWXlo8/9ST51kGvU1xyPD/YlTg8VSul3j/OkB613XXS6Ae+UK07gUfgcXLx+IhuP7c4kRczelJtI6c9Adwg0Htwdl59PvbSISM1hjF08p30YbCgz8FZmyO8rT/W3idVWOelalA/dWAFTIVFCaA9CiNLOS7KpRulsE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XVEzyLMV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XVEzyLMV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715331530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=67Tjslp/ob1JH0/G6tnxQC8C57IHxzX8yRCE85hX0kc=; b=XVEzyLMVEp4yaLD7pFXVlGUakIRU5i+EFm6S6/Utxi9mo22HALhfat2B6J/IinkWSC8Hc7 FjZEI/cP15Xa7YRnviHznNXQ0C6HyBYZa6E4HWei1ddPbRINGGnwzgMDoUJKjduaUo5TnR /Rjesb/Dj9ZLrjrQGaimC41hJacmE1U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-FUWC7ru5OjOluU0xYKoIlA-1; Fri, 10 May 2024 04:57:35 -0400 X-MC-Unique: FUWC7ru5OjOluU0xYKoIlA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C75A9800CA5; Fri, 10 May 2024 08:57:34 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.39.192.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FBFE5751D3; Fri, 10 May 2024 08:57:33 +0000 (UTC) From: Jose Ignacio Tornos Martinez To: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lucas.demarchi@intel.com, Jose Ignacio Tornos Martinez Subject: [PATCH v3] module: create weak dependecies Date: Fri, 10 May 2024 10:57:22 +0200 Message-ID: <20240510085726.327831-1-jtornosm@redhat.com> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 It has been seen that for some network mac drivers (i.e. lan78xx) the related module for the phy is loaded dynamically depending on the current hardware. In this case, the associated phy is read using mdio bus and then the associated phy module is loaded during runtime (kernel function phy_request_driver_module). However, no software dependency is defined, so the user tools will no be able to get this dependency. For example, if dracut is used and the hardware is present, lan78xx will be included but no phy module will be added, and in the next restart the device will not work from boot because no related phy will be found during initramfs stage. In order to solve this, we could define a normal 'pre' software dependency in lan78xx module with all the possible phy modules (there may be some), but proceeding in that way, all the possible phy modules would be loaded while only one is necessary. The idea is to create a new type of dependency, that we are going to call 'weak' to be used only by the user tools that need to detect this situation. In that way, for example, dracut could check the 'weak' dependency of the modules involved in order to install these dependencies in initramfs too. That is, for the commented lan78xx module, defining the 'weak' dependency with the possible phy modules list, only the necessary phy would be loaded on demand keeping the same behavior, but all the possible phy modules would be available from initramfs. The 'weak' dependency support has been included in kmod: https://github.com/kmod-project/kmod/commit/05828b4a6e9327a63ef94df544a042b5e9ce4fe7 But, take into account that this can only be used if depmod is new enough. If it isn't, depmod will have the same behavior as always (keeping backward compatibility) and the information for the 'weak' dependency will not be provided. Signed-off-by: Jose Ignacio Tornos Martinez Reviewed-by: Lucas De Marchi --- V2 -> V3: - Include note about backward compatibility. - Balance the /* and */. V1 -> V2: - Include reference to 'weak' dependency support in kmod. include/linux/module.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/module.h b/include/linux/module.h index 1153b0d99a80..2a056017df5b 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -173,6 +173,12 @@ extern void cleanup_module(void); */ #define MODULE_SOFTDEP(_softdep) MODULE_INFO(softdep, _softdep) +/* + * Weak module dependencies. See man modprobe.d for details. + * Example: MODULE_WEAKDEP("module-foo") + */ +#define MODULE_WEAKDEP(_weakdep) MODULE_INFO(weakdep, _weakdep) + /* * MODULE_FILE is used for generating modules.builtin * So, make it no-op when this is being built as a module