[v1,0/7] Various NFS fscache cleanups

Message

David Wysochanski Oct. 3, 2021, 7:22 p.m. UTC

This patchset is on top of David Howells fscache-iter-3 branch, which
he posted v2 recently
https://lore.kernel.org/all/[e-mail]/

The first patch in this series should probably be merged into David Howells
3/8 patch of that series.  Otherwise, these patches are applied on top of
his series, and this series is mostly orthogonal to fscache-iter-3 branch.

The second and third patches are a few cleanups, and the last 4 remove
dfprintks in the NFS fscache code, and add in few new tracepoints.  I am
not sure about the new tracepoints, but I think we need at least a couple
tracepoints with the NFS fscache interface to tie in NFS tracepoints with
fscache and cachefiles ones.

These have been tested with xfstests against various NFS versions (NFS4.0,
NFS4.1, and NFS4.2) and servers (hammerspace, Netapp Ontap 9.x, RHEL8.4),
and all tracepoints enabled per the following:
trace-cmd start -e fscache:* -e nfs:* -e nfs4:* -e cachefiles:*

I plan to use this series at the BakeAThon this week for further testing
and refinement.

Dave Wysochanski (7):
  NFS: Fixup patch 3/8 of fscache-iter-3 v2
  NFS: Use nfs_i_fscache() consistently within NFS fscache code
  NFS: Cleanup usage of nfs_inode in fscache interface and handle i_size
    properly
  NFS: Convert NFS fscache enable/disable dfprintks to tracepoints
  NFS: Replace dfprintks in favor of tracepoints in fscache IO paths
  NFS: Remove remaining dfprintks related to fscache cookies
  NFS: Remove remaining usages of NFSDBG_FSCACHE

 fs/nfs/fscache-index.c      |  2 -
 fs/nfs/fscache.c            | 70 +++++++++-----------------------
 fs/nfs/fscache.h            |  8 ++--
 fs/nfs/nfstrace.h           | 99 +++++++++++++++++++++++++++++++++++++++++++++
 include/uapi/linux/nfs_fs.h |  2 +-
 5 files changed, 123 insertions(+), 58 deletions(-)