From patchwork Thu Apr 7 17:43:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 12805589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DC3C433F5 for ; Thu, 7 Apr 2022 17:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346522AbiDGRpe (ORCPT ); Thu, 7 Apr 2022 13:45:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346505AbiDGRpc (ORCPT ); Thu, 7 Apr 2022 13:45:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3427322C6F8 for ; Thu, 7 Apr 2022 10:43:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D19F9B826B6 for ; Thu, 7 Apr 2022 17:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6703FC385A0; Thu, 7 Apr 2022 17:43:17 +0000 (UTC) Subject: [PATCH v3 0/2] Fix request deferral for NFS/RDMA From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: rostedt@goodmis.org Date: Thu, 07 Apr 2022 13:43:16 -0400 Message-ID: <164935330144.76813.17862521591948764594.stgit@klimt.1015granger.net> User-Agent: StGit/1.5.dev1+g8516920 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Last week Trond reported a server crash in svc_rdma_sendto() that seemed related to deferral of a request incoming on an RPC/RDMA transport. A link to that report appears in the first patch below. The first patch in this series addresses the crash, and the second fixes a related observability crash. The other patches from v1 of this series have been postponed to 5.19. Comments, opinions, and Reviewed-by's are appreciated! Since v2: - Fix "has unsafe dereference" warnings in patch 2/2 Since v1: - Series trimmed down to just what will go to 5.18-rc - 2nd patch re-worked so it can be backported to recent stable - Addressed a few checkpatch.pl nits --- Chuck Lever (2): SUNRPC: Fix NFSD's request deferral on RDMA transports SUNRPC: Fix the svc_deferred_event trace class include/linux/sunrpc/svc.h | 1 + include/trace/events/sunrpc.h | 7 ++++--- net/sunrpc/svc_xprt.c | 3 +++ net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) -- Chuck Lever