From patchwork Wed May 11 21:52:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 12846647 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F5A2C433F5 for ; Wed, 11 May 2022 21:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238018AbiEKVww (ORCPT ); Wed, 11 May 2022 17:52:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbiEKVwu (ORCPT ); Wed, 11 May 2022 17:52:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58D44F68A1 for ; Wed, 11 May 2022 14:52:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 11490B82630 for ; Wed, 11 May 2022 21:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63C33C340EE; Wed, 11 May 2022 21:52:46 +0000 (UTC) Subject: [PATCH RFC 0/2] Fix "sleep while locked" in RELEASE_LOCKOWNER From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: trondmy@hammerspace.com, bfields@fieldses.org, jlayton@redhat.com, dai.ngo@oracle.com Date: Wed, 11 May 2022 17:52:44 -0400 Message-ID: <165230584037.5906.5496655737644872339.stgit@klimt.1015granger.net> User-Agent: StGit/1.5.dev1+g8516920 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org This short series passes the usual tests on NFSv4.0. We still do not have a reproducer for the splat, though, so it's not known if the issue has been fully addressed. Because this is a long-standing issue and we do not have a reproducer, I'm inclined to be conservative and push this in v5.19 rather than in v5.18-rc. Thoughts, questions, and virtual rotten fruit welcome. --- Chuck Lever (2): NFSD: nfsd4_release_lockowner() should drop clp->cl_lock sooner NFSD: nfsd_file_put() can sleep fs/nfsd/filecache.c | 2 ++ fs/nfsd/nfs4state.c | 56 ++++++++++++++++++++------------------------- 2 files changed, 27 insertions(+), 31 deletions(-) -- Chuck Lever