[v2,0/3] Backchannel fixes

Message

Trond Myklebust Oct. 17, 2019, 1:02 p.m. UTC

A set of patches to ensure the backchannel lifetime cannot exceed the
lifetime of the transport to which it is attached.

v2:
 - Fix the case where !defined(CONFIG_SUNRPC_BACKCHANNEL)
 - Don't allow xprt->bc_alloc_max to underflow in xprt_destroy_bc()

Trond Myklebust (3):
  SUNRPC: The TCP back channel mustn't disappear while requests are
    outstanding
  SUNRPC: The RDMA back channel mustn't disappear while requests are
    outstanding
  SUNRPC: Destroy the back channel when we destroy the host transport

 include/linux/sunrpc/bc_xprt.h    | 5 +++++
 net/sunrpc/backchannel_rqst.c     | 7 ++++---
 net/sunrpc/xprt.c                 | 5 +++++
 net/sunrpc/xprtrdma/backchannel.c | 2 ++
 4 files changed, 16 insertions(+), 3 deletions(-)

Comments

NeilBrown Oct. 17, 2019, 9:48 p.m. UTC | #1

On Thu, Oct 17 2019, Trond Myklebust wrote:

> A set of patches to ensure the backchannel lifetime cannot exceed the
> lifetime of the transport to which it is attached.
>
> v2:
>  - Fix the case where !defined(CONFIG_SUNRPC_BACKCHANNEL)
>  - Don't allow xprt->bc_alloc_max to underflow in xprt_destroy_bc()
>
> Trond Myklebust (3):
>   SUNRPC: The TCP back channel mustn't disappear while requests are
>     outstanding
>   SUNRPC: The RDMA back channel mustn't disappear while requests are
>     outstanding
>   SUNRPC: Destroy the back channel when we destroy the host transport
>
>  include/linux/sunrpc/bc_xprt.h    | 5 +++++
>  net/sunrpc/backchannel_rqst.c     | 7 ++++---
>  net/sunrpc/xprt.c                 | 5 +++++
>  net/sunrpc/xprtrdma/backchannel.c | 2 ++
>  4 files changed, 16 insertions(+), 3 deletions(-)
>

All look good to me - thanks a lot.
Reviewed-by: NeilBrown <[e-mail]>

NeilBrown