| Message ID | 20220428144308.32639-1-pvorel@suse.cz (mailing list archive) |
|---|---|
| Headers | show |
| Series | Remove RPC rup and rusers tests | expand |
Hi all, I'm sorry, I again used the old mail address of automated-testing ML. Please have look at this patchset: https://lore.kernel.org/ltp/20220428144308.32639-1-pvorel@suse.cz/ https://patchwork.ozlabs.org/project/ltp/list/?series=297407&state=* Kind regards, Petr > Hi all, > IMHO safe to remove these two tests, but sending to broad audience in > case anybody really want to have these 2 kept (they'd be rewritten to > new LTP shell API). > BTW in long term I'd prefer to remove all RPC tests > (testcases/network/rpc/ directory). IMHO they should be part of libtirpc > (which has no tests), but these tests are old, messy and I'm not sure > how relevant they are nowadays. > Kind regards, > Petr > Petr Vorel (3): > rpc: Remove rup01.sh test > rpc: Remove rusers01.sh test > rpc: Move rest of RPC tests to runtest/net.rpc_tests > runtest/net.rpc | 8 --- > runtest/net.rpc_tests | 3 ++ > scenario_groups/network | 1 - > .../network/rpc/basic_tests/rup/Makefile | 29 ----------- > .../network/rpc/basic_tests/rup/rup01.sh | 50 ------------------- > .../network/rpc/basic_tests/rusers/Makefile | 29 ----------- > .../rpc/basic_tests/rusers/rusers01.sh | 50 ------------------- > testscripts/network.sh | 4 +- > 8 files changed, 4 insertions(+), 170 deletions(-) > delete mode 100644 runtest/net.rpc > delete mode 100644 testcases/network/rpc/basic_tests/rup/Makefile > delete mode 100755 testcases/network/rpc/basic_tests/rup/rup01.sh > delete mode 100644 testcases/network/rpc/basic_tests/rusers/Makefile > delete mode 100755 testcases/network/rpc/basic_tests/rusers/rusers01.sh
Hi! Looks like rstatd wasn't included in distributions to begin with, so there is no point to keep tests for it. https://bugs.gentoo.org/show_bug.cgi?id=115806 https://access.redhat.com/solutions/34127 https://www.ibm.com/support/pages/rstatd-not-installed-or-distributed-suse-linux-enterprise-server-10
Hi Cyril, > Hi! > Looks like rstatd wasn't included in distributions to begin with, so > there is no point to keep tests for it. > https://bugs.gentoo.org/show_bug.cgi?id=115806 > https://access.redhat.com/solutions/34127 > https://www.ibm.com/support/pages/rstatd-not-installed-or-distributed-suse-linux-enterprise-server-10 Thanks for the links. FYI Debian has had it for a long time in rstatd package: https://packages.debian.org/search?suite=default§ion=all&arch=any&searchon=contents&keywords=rstatd https://packages.debian.org/bullseye/rstatd https://tracker.debian.org/pkg/rstatd but that IMHO no reason to keep these tests. Kind regards, Petr
Hi! > > Looks like rstatd wasn't included in distributions to begin with, so > > there is no point to keep tests for it. > > > https://bugs.gentoo.org/show_bug.cgi?id=115806 > > https://access.redhat.com/solutions/34127 > > https://www.ibm.com/support/pages/rstatd-not-installed-or-distributed-suse-linux-enterprise-server-10 > > Thanks for the links. > FYI Debian has had it for a long time in rstatd package: > https://packages.debian.org/search?suite=default§ion=all&arch=any&searchon=contents&keywords=rstatd > https://packages.debian.org/bullseye/rstatd > https://tracker.debian.org/pkg/rstatd > > but that IMHO no reason to keep these tests. For debian we have: https://qa.debian.org/popcon.php?package=rstatd 0.07% of debian installations installed rstatd.
> Hi! > > > Looks like rstatd wasn't included in distributions to begin with, so > > > there is no point to keep tests for it. > > > https://bugs.gentoo.org/show_bug.cgi?id=115806 > > > https://access.redhat.com/solutions/34127 > > > https://www.ibm.com/support/pages/rstatd-not-installed-or-distributed-suse-linux-enterprise-server-10 > > Thanks for the links. > > FYI Debian has had it for a long time in rstatd package: > > https://packages.debian.org/search?suite=default§ion=all&arch=any&searchon=contents&keywords=rstatd > > https://packages.debian.org/bullseye/rstatd > > https://tracker.debian.org/pkg/rstatd > > but that IMHO no reason to keep these tests. > For debian we have: > https://qa.debian.org/popcon.php?package=rstatd > 0.07% of debian installations installed rstatd. Agree, both are dead, that's why I want to remove it. Because although it'd be easy to fix failing test, I have no reason to improve popcon statistics just to fix tests which nobody needs :). Kind regards, Petr
Hi! Patchset pushed, thanks.